Skip to content

Commit 400e279

Browse files
committed
Use JavaFX 19 in demo
1 parent 35749d1 commit 400e279

3 files changed

Lines changed: 2 additions & 6 deletions

File tree

‎README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ hierarchical and non-cyclic.
192192

193193
## Requirements <a name="requirements"></a>
194194

195-
Java 11+ and JavaFX 11+.
195+
Java 11+ and JavaFX 19.
196196

197197
## Dependencies <a name="dependencies"></a>
198198

‎mvvm4fx-demo/pom.xml‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@
1515

1616
<properties>
1717
<maven.deploy.skip>true</maven.deploy.skip>
18-
<!-- javafx 19 shows system notification in Ubuntu when closing -->
19-
<javafx.version>24</javafx.version>
2018
</properties>
2119

2220
<dependencies>
@@ -31,17 +29,14 @@
3129
<dependency>
3230
<groupId>org.openjfx</groupId>
3331
<artifactId>javafx-base</artifactId>
34-
<version>${javafx.version}</version>
3532
</dependency>
3633
<dependency>
3734
<groupId>org.openjfx</groupId>
3835
<artifactId>javafx-graphics</artifactId>
39-
<version>${javafx.version}</version>
4036
</dependency>
4137
<dependency>
4238
<groupId>org.openjfx</groupId>
4339
<artifactId>javafx-controls</artifactId>
44-
<version>${javafx.version}</version>
4540
</dependency>
4641
<dependency>
4742
<groupId>org.apache.logging.log4j</groupId>

‎mvvm4fx-demo/src/main/java/com/techsenger/mvvm4fx/demo/PersonRegistryView.java‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@ protected void addHandlers(PersonRegistryViewModel viewModel) {
9696
var dialog = dialogV.getDialog();
9797
dialog.initOwner(stage);
9898
dialog.initModality(Modality.WINDOW_MODAL);
99+
// javafx 19 has a bug - it shows a system notification in Ubuntu when closing
99100
var result = dialog.showAndWait();
100101
viewModel.add(result);
101102
dialogV.deinitialize();

0 commit comments

Comments
 (0)