From fa8e25b99c89622f46af8d14e8f6a90925b892e2 Mon Sep 17 00:00:00 2001 From: Richard Osborne Date: Tue, 25 Aug 2026 16:09:47 -0500 Subject: [PATCH] Upgrade to Electron 43 --- .github/workflows/build.yml | 12 ++++++------ CMakeLists.txt | 2 +- package.json | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 0270210..6c43977 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -19,7 +19,7 @@ env: BUILD_DIRECTORY: "build" DISTRIBUTE_DIRECTORY: "distribute" RELEASE_BUCKET: "obs-studio-deployment" - ELECTRON_VERSION: "v29.4.3" + ELECTRON_VERSION: "v43.2.0" permissions: contents: read @@ -27,7 +27,7 @@ permissions: jobs: build: name: 'Build a package' - runs-on: windows-latest + runs-on: windows-2022 steps: - uses: actions/checkout@v3 - name: Show GitHub context @@ -39,9 +39,9 @@ jobs: run: echo "VERSION=${GITHUB_REF/refs\/tags\//}" >> $GITHUB_OUTPUT shell: bash - name: Install Node.js - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: - node-version: '16.x' + node-version: '24.x' - name: Install dependencies run: yarn install --immutable --immutable-cache --check-cache - name: Add MSBuild to PATH @@ -66,7 +66,7 @@ jobs: upload_debug_symbols: needs: build name: 'Upload debug symbols' - runs-on: windows-latest + runs-on: windows-2022 if: startsWith(github.ref, 'refs/tags/') steps: - name: Get the version of aws cli @@ -108,7 +108,7 @@ jobs: upload_release_package: needs: build name: 'Upload release package' - runs-on: windows-latest + runs-on: windows-2022 if: startsWith(github.ref, 'refs/tags/') steps: - name: Get the version diff --git a/CMakeLists.txt b/CMakeLists.txt index 9fe3c1e..70831e2 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -8,7 +8,7 @@ set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} "${CMAKE_SOURCE_DIR}/cmake") SET(NODEJS_URL "https://artifacts.electronjs.org/headers/dist" CACHE STRING "Node.JS URL") SET(NODEJS_NAME "iojs" CACHE STRING "Node.JS Name") -SET(NODEJS_VERSION "v29.4.3" CACHE STRING "Node.JS Version") +SET(NODEJS_VERSION "v43.2.0" CACHE STRING "Node.JS Version") include(NodeJS) diff --git a/package.json b/package.json index f2c3747..70bd8e9 100644 --- a/package.json +++ b/package.json @@ -31,7 +31,7 @@ }, "devDependencies": { "@types/node": "12.7.2", - "electron": "29.4.3", + "electron": "43.2.0", "fs-extra": "9.0.0", "prettier": "1.16.4", "minimist":"1.2.6",