getSessionId to return null on empty session id, avoiding strtr() warnings

Author: spaze

src/SensitiveValueSanitizer.php

@@ -49,7 +49,7 @@ private function getSessionId(): ?string
 		} else {
 			$sessionId = $_COOKIE[$sessionName] ?? null;
 		}
-		return is_string($sessionId) ? $sessionId : null;
+		return is_string($sessionId) && $sessionId !== '' ? $sessionId : null;
 	}
 
 

tests/PhpInfoTest.phpt

@@ -135,6 +135,18 @@ class PhpInfoTest extends TestCase
 		Assert::contains('🍕', $html);
 	}
 
+
+	public function testGetHtmlEmptySessionCookie(): void
+	{
+		session_write_close();
+		$_SERVER['HTTP_COOKIE'] = 'PHPSESSID=';
+		$_COOKIE['PHPSESSID'] = '';
+		session_start();
+		Assert::noError(function (): void {
+			(new PhpInfo())->getHtml();
+		});
+	}
+
 }
 
 (new PhpInfoTest())->run();