build: migrate to eslint flat config and typescript 6

Author: k80bowman

.eslintignore

@@ -0,0 +1,76 @@
+{
+  "src/agentActivation.ts": {
+    "no-useless-assignment": {
+      "count": 1
+    }
+  },
+  "src/commands/agent/adl/create.ts": {
+    "sf-plugin/flag-min-max-default": {
+      "count": 1
+    }
+  },
+  "src/commands/agent/adl/upload.ts": {
+    "sf-plugin/flag-min-max-default": {
+      "count": 1
+    }
+  },
+  "src/commands/agent/generate/agent-spec.ts": {
+    "@typescript-eslint/no-unused-vars": {
+      "count": 1
+    }
+  },
+  "src/commands/agent/generate/test-spec.ts": {
+    "@typescript-eslint/no-unused-vars": {
+      "count": 2
+    }
+  },
+  "src/commands/agent/publish/authoring-bundle.ts": {
+    "@typescript-eslint/explicit-function-return-type": {
+      "count": 1
+    }
+  },
+  "src/commands/agent/test/create.ts": {
+    "complexity": {
+      "count": 1
+    }
+  },
+  "src/commands/agent/test/run.ts": {
+    "sf-plugin/flag-min-max-default": {
+      "count": 1
+    }
+  },
+  "src/components/agent-preview-react.tsx": {
+    "@typescript-eslint/explicit-function-return-type": {
+      "count": 1
+    },
+    "@typescript-eslint/no-unused-vars": {
+      "count": 1
+    }
+  },
+  "src/flags.ts": {
+    "@typescript-eslint/no-unused-vars": {
+      "count": 1
+    }
+  },
+  "test/nuts/agent.activate.nut.ts": {
+    "@typescript-eslint/no-unused-vars": {
+      "count": 1
+    }
+  },
+  "test/nuts/shared-setup.ts": {
+    "@typescript-eslint/no-unused-vars": {
+      "count": 1
+    },
+    "@typescript-eslint/prefer-promise-reject-errors": {
+      "count": 1
+    }
+  },
+  "test/nuts/z2.agent.publish.nut.ts": {
+    "@typescript-eslint/no-unused-vars": {
+      "count": 1
+    },
+    "@typescript-eslint/prefer-promise-reject-errors": {
+      "count": 1
+    }
+  }
+}

.eslintrc.cjs

@@ -0,0 +1 @@
+export { default } from 'eslint-config-salesforce-typescript';

eslint-suppressions.json

@@ -12,11 +12,11 @@
     "@inquirer/prompts": "^7.10.1",
     "@oclif/core": "^5.0.0",
     "@oclif/multi-stage-output": "^1.0.0",
-    "@salesforce/agents": "^2.1.0",
-    "@salesforce/core": "^9.1.8",
+    "@salesforce/agents": "^2.3.0",
+    "@salesforce/core": "^9.1.10",
     "@salesforce/kit": "^4.0.0",
     "@salesforce/sf-plugins-core": "^13.0.4",
-    "@salesforce/source-deploy-retrieve": "^13.3.0",
+    "@salesforce/source-deploy-retrieve": "^13.3.1",
     "@salesforce/types": "1.8.0",
     "ansis": "^3.17.0",
     "fast-xml-parser": "^5.11.1",
@@ -31,19 +31,25 @@
     "@oclif/plugin-command-snapshot": "^6.0.0",
     "@oclif/test": "^5.0.0",
     "@salesforce/cli-plugins-testkit": "^5.3.66",
-    "@salesforce/dev-scripts": "^11.0.4",
-    "@salesforce/plugin-command-reference": "^3.1.132",
+    "@salesforce/dev-scripts": "^14.0.0",
+    "@salesforce/plugin-command-reference": "^3.1.133",
+    "@types/chai": "^4.3.17",
     "@types/inquirer": "^9.0.10",
+    "@types/mocha": "^10.0.10",
+    "@types/node": "^18",
     "@types/react": "^18.3.31",
+    "@types/sinon": "^10.0.20",
+    "eslint": "^10.4.0",
+    "eslint-config-salesforce-typescript": "^6.0.0",
     "eslint-config-xo": "^0.50.0",
     "eslint-config-xo-react": "^0.27.0",
     "eslint-plugin-react": "^7.37.5",
     "eslint-plugin-react-hooks": "^4.6.2",
-    "eslint-plugin-sf-plugin": "^1.20.33",
+    "eslint-plugin-sf-plugin": "^3.0.0",
     "esmock": "^2.7.6",
-    "oclif": "^5.0.0",
+    "oclif": "^5.0.1",
     "ts-node": "^10.9.2",
-    "typescript": "^5.9.3"
+    "typescript": "^6.0.3"
   },
   "engines": {
     "node": ">=22.0.0"
@@ -179,6 +185,7 @@
         "src/**/*.ts",
         "test/**/*.ts",
         "messages/**",
+        "**/eslint.config.*",
         "**/.eslint*",
         "**/tsconfig.json"
       ],

eslint.config.mjs

@@ -224,7 +224,7 @@ export default class AgentCreateSpec extends SfCommand<AgentCreateSpecResult> {
       (flags.tone as AgentTone) ??
       inputSpec?.tone ??
       (flags['full-interview'] ? await promptForFlag(FLAGGABLE_PROMPTS.tone) : 'casual');
-    tone = validateTone(tone as AgentTone);
+    tone = validateTone(tone);
     // const primaryLanguage =
     //   flags['primary-language'] ??
     //   inputSpec?.primaryLanguage ??

package.json

@@ -20,7 +20,6 @@ import {
   type McpServerCreateOutput,
   type McpServerCreateInput,
   type McpServerAuthorizationInput,
-  type McpAuthType,
 } from '@salesforce/agents';
 
 Messages.importMessagesDirectoryFromMetaUrl(import.meta.url);
@@ -77,7 +76,7 @@ export default class ApiCatalogMcpServerCreate extends SfCommand<McpServerCreate
     const { flags } = await this.parse(ApiCatalogMcpServerCreate);
     const connection = flags['target-org'].getConnection(flags['api-version']);
 
-    const authType = flags['auth-type'] as McpAuthType;
+    const authType = flags['auth-type'];
 
     if (authType === 'OAUTH') {
       if (!flags['identity-provider'] || !flags['client-id'] || !flags['client-secret'] || !flags.scope) {

src/commands/agent/generate/agent-spec.ts

@@ -20,7 +20,6 @@ import {
   type McpServerOutput,
   type McpServerUpdateInput,
   type McpServerAuthorizationInput,
-  type McpAuthType,
 } from '@salesforce/agents';
 
 Messages.importMessagesDirectoryFromMetaUrl(import.meta.url);
@@ -89,16 +88,11 @@ export default class ApiCatalogMcpServerUpdate extends SfCommand<ApiCatalogMcpSe
       input.serverUrl = flags['server-url'];
     }
 
-    const authType = flags['auth-type'] as McpAuthType | undefined;
+    const authType = flags['auth-type'];
 
     if (authType) {
       if (authType === 'OAUTH') {
-        if (
-          !flags['identity-provider'] ||
-          !flags['client-id'] ||
-          !flags['client-secret'] ||
-          !flags.scope
-        ) {
+        if (!flags['identity-provider'] || !flags['client-id'] || !flags['client-secret'] || !flags.scope) {
           throw new SfError(messages.getMessage('error.missingOauthFields'), 'MissingOauthFields', [], 1);
         }
 

src/commands/agent/mcp/create.ts

@@ -64,7 +64,7 @@ const FLAGGABLE_PROMPTS = {
   },
 };
 
-async function promptUntilUniqueName(connection: Connection, name?: string | undefined): Promise<string | undefined> {
+async function promptUntilUniqueName(connection: Connection, name?: string): Promise<string | undefined> {
   const apiName = name ?? (await promptForFlag(FLAGGABLE_PROMPTS['api-name']));
   const existingDefinitions = await AgentTest.list(connection);
   if (existingDefinitions.some((d) => d.fullName === apiName)) {

src/commands/agent/mcp/update.ts

@@ -169,7 +169,7 @@ export default class AgentTestResume extends SfCommand<AgentTestRunResult> {
       process.exitCode = 1;
     }
 
-    return { ...response, runId, status: 'COMPLETED' } as AgentTestRunResult;
+    return { ...response, runId, status: 'COMPLETED' };
   }
 
   protected catch(error: Error | SfError | CLIError): Promise<never> {