From 91f8ece6e18052a618b61cc599912ca684365860 Mon Sep 17 00:00:00 2001 From: Mohamed El Ghazali <48661966+mohamedelghazali@users.noreply.github.com> Date: Wed, 18 Nov 2026 22:32:45 +0100 Subject: [PATCH 1/5] Add isScrollableLayout to QuranPageLayout --- .../quran/labs/androidquran/view/QuranPageLayout.java | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/com/quran/labs/androidquran/view/QuranPageLayout.java b/app/src/main/java/com/quran/labs/androidquran/view/QuranPageLayout.java index 606c6714f2..9eb2f91fbf 100644 --- a/app/src/main/java/com/quran/labs/androidquran/view/QuranPageLayout.java +++ b/app/src/main/java/com/quran/labs/androidquran/view/QuranPageLayout.java @@ -89,7 +89,7 @@ public void initialize() { viewPaddingLarge = resources.getDimensionPixelSize(R.dimen.page_margin_large); LayoutParams lp = new LayoutParams(LayoutParams.MATCH_PARENT, LayoutParams.MATCH_PARENT); - if (isLandscape && shouldWrapWithScrollView()) { + if (isScrollableLayout(resources)) { scrollView = new ObservableScrollView(context); scrollView.setFillViewport(true); addView(scrollView, lp); @@ -197,6 +197,13 @@ protected void onDraw(Canvas canvas) { protected abstract View generateContentView(@NonNull Context context, boolean isLandscape); +protected boolean isScrollableLayout(@NonNull Resources resources) { +final Configuration config = resources.getConfiguration(); +final boolean isLandscape = config.orientation == Configuration.ORIENTATION_LANDSCAPE; +final boolean isShortViewport = config.screenWidthDp > 0 && config.screenHeightDp > 0 && config.screenHeightDp < config.screenWidthDp * 1.4f; +return (isLandscape || isShortViewport) && shouldWrapWithScrollView(); +} + protected boolean shouldWrapWithScrollView() { return true; } From 59aa6a8a77d919670d2628907658f6b9e0c6c254 Mon Sep 17 00:00:00 2001 From: Mohamed El Ghazali <48661966+mohamedelghazali@users.noreply.github.com> Date: Wed, 18 Nov 2026 22:33:45 +0100 Subject: [PATCH 2/5] Refactor setIsScrollable method call in generateContentView --- .../com/quran/labs/androidquran/view/QuranImagePageLayout.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/main/java/com/quran/labs/androidquran/view/QuranImagePageLayout.kt b/app/src/main/java/com/quran/labs/androidquran/view/QuranImagePageLayout.kt index cc7c8b2770..074bce886b 100644 --- a/app/src/main/java/com/quran/labs/androidquran/view/QuranImagePageLayout.kt +++ b/app/src/main/java/com/quran/labs/androidquran/view/QuranImagePageLayout.kt @@ -25,7 +25,7 @@ open class QuranImagePageLayout(context: Context) : QuranPageLayout(context) { override fun generateContentView(context: Context, isLandscape: Boolean): View { imageView = HighlightingImageView(context).apply { adjustViewBounds = true - setIsScrollable(isLandscape && shouldWrapWithScrollView(), isLandscape) + setIsScrollable(isScrollableLayout(context.resources), isLandscape) } return imageView } From 834c5184f59bddb5c72167faeac904aa5f561e2f Mon Sep 17 00:00:00 2001 From: Mohamed El Ghazali <48661966+mohamedelghazali@users.noreply.github.com> Date: Wed, 18 Nov 2026 22:35:15 +0100 Subject: [PATCH 3/5] Add window insets listener to non-restoring ViewPager Set on apply window insets listener for non-restoring ViewPager to update padding based on navigation bar insets. --- .../java/com/quran/labs/androidquran/ui/PagerActivity.kt | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/app/src/main/java/com/quran/labs/androidquran/ui/PagerActivity.kt b/app/src/main/java/com/quran/labs/androidquran/ui/PagerActivity.kt index 78c1dace9f..c4d26dfa7a 100644 --- a/app/src/main/java/com/quran/labs/androidquran/ui/PagerActivity.kt +++ b/app/src/main/java/com/quran/labs/androidquran/ui/PagerActivity.kt @@ -508,6 +508,11 @@ class PagerActivity : AppCompatActivity(), AudioBarListener, OnBookmarkTagsUpdat } val nonRestoringViewPager = findViewById(R.id.quran_pager) +ViewCompat.setOnApplyWindowInsetsListener(nonRestoringViewPager) { view, windowInsets -> +val insets = windowInsets.getInsets(WindowInsetsCompat.Type.navigationBars()) +view.updatePadding(bottom = insets.bottom) +windowInsets +} nonRestoringViewPager.setIsDualPagesInLandscape( QuranUtils.isDualPagesInLandscape(this, quranScreenInfo) ) From 25cb9ad131b637fa4d686342a7f599d2ddab43d3 Mon Sep 17 00:00:00 2001 From: Mohamed El Ghazali <48661966+mohamedelghazali@users.noreply.github.com> Date: Wed, 18 Nov 2026 22:36:20 +0100 Subject: [PATCH 4/5] Implement tests for QuranPageLayout scrolling behavior Add unit tests for QuranPageLayout and QuranTabletImagePageLayout scroll behavior in different configurations. --- .../androidquran/view/QuranPageLayoutTest.kt | 55 +++++++++++++++++++ 1 file changed, 55 insertions(+) create mode 100644 app/src/test/java/com/quran/labs/androidquran/view/QuranPageLayoutTest.kt diff --git a/app/src/test/java/com/quran/labs/androidquran/view/QuranPageLayoutTest.kt b/app/src/test/java/com/quran/labs/androidquran/view/QuranPageLayoutTest.kt new file mode 100644 index 0000000000..0922a4acad --- /dev/null +++ b/app/src/test/java/com/quran/labs/androidquran/view/QuranPageLayoutTest.kt @@ -0,0 +1,55 @@ +package com.quran.labs.androidquran.view + +import android.content.Context +import android.content.res.Configuration +import androidx.test.core.app.ApplicationProvider +import com.quran.labs.androidquran.TestApplication +import org.junit.Assert.assertFalse +import org.junit.Assert.assertTrue +import org.junit.Test +import org.junit.runner.RunWith +import org.robolectric.RobolectricTestRunner +import org.robolectric.annotation.Config + +@Config(application = TestApplication::class, sdk = [33]) +@RunWith(RobolectricTestRunner::class) +class QuranPageLayoutTest { + +@Test +fun fullScreenPortraitIsNotScrollable() { +val context = createContext(411, 915, Configuration.ORIENTATION_PORTRAIT) +val layout = QuranImagePageLayout(context) +assertFalse(layout.canScroll()) +} + +@Test +fun constrainedSplitScreenPortraitIsScrollable() { +val context = createContext(411, 420, Configuration.ORIENTATION_PORTRAIT) +val layout = QuranImagePageLayout(context) +assertTrue(layout.canScroll()) +} + +@Test +fun landscapeIsScrollable() { +val context = createContext(915, 411, Configuration.ORIENTATION_LANDSCAPE) +val layout = QuranImagePageLayout(context) +assertTrue(layout.canScroll()) +} + +@Test +fun tabletLayoutInConstrainedPortraitIsNotScrollable() { +val context = createContext(411, 420, Configuration.ORIENTATION_PORTRAIT) +val layout = QuranTabletImagePageLayout(context) +assertFalse(layout.canScroll()) +} + +private fun createContext(widthDp: Int, heightDp: Int, orientation: Int): Context { +val baseContext = ApplicationProvider.getApplicationContext() +val config = Configuration(baseContext.resources.configuration).apply { +screenWidthDp = widthDp +screenHeightDp = heightDp +this.orientation = orientation +} +return baseContext.createConfigurationContext(config) +} +} From 1aec7f1febb0a3b3673341265712be3c71e1d0be Mon Sep 17 00:00:00 2001 From: Mohamed El Ghazali <48661966+mohamedelghazali@users.noreply.github.com> Date: Wed, 18 Nov 2026 22:45:45 +0100 Subject: [PATCH 5/5] Update import for TestApplication class --- .../com/quran/labs/androidquran/view/QuranPageLayoutTest.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/test/java/com/quran/labs/androidquran/view/QuranPageLayoutTest.kt b/app/src/test/java/com/quran/labs/androidquran/view/QuranPageLayoutTest.kt index 0922a4acad..bcdd339a79 100644 --- a/app/src/test/java/com/quran/labs/androidquran/view/QuranPageLayoutTest.kt +++ b/app/src/test/java/com/quran/labs/androidquran/view/QuranPageLayoutTest.kt @@ -3,7 +3,7 @@ package com.quran.labs.androidquran.view import android.content.Context import android.content.res.Configuration import androidx.test.core.app.ApplicationProvider -import com.quran.labs.androidquran.TestApplication +import com.quran.labs.androidquran.base.TestApplication import org.junit.Assert.assertFalse import org.junit.Assert.assertTrue import org.junit.Test