fix mr rr (#41)

Author: smnandre

src/API/APIRequestContext.php

@@ -111,8 +111,6 @@ public function fetch(string $urlOrRequest, array $options = []): APIResponseInt
         if (!isset($response['response']) || !is_array($response['response'])) {
             throw new ProtocolErrorException('Invalid API response from transport', 0);
         }
-
-        // Ensure we pass an array<string, mixed> to APIResponse
         $respData = [];
         foreach ($response['response'] as $key => $value) {
             if (is_string($key)) {

src/API/APIResponse.php

@@ -159,7 +159,21 @@ public function json(): array
         try {
             $decoded = json_decode($body, true, 512, \JSON_THROW_ON_ERROR);
 
-            return is_array($decoded) ? $decoded : [];
+            if (!is_array($decoded)) {
+                return [];
+            }
+
+            $result = [];
+            foreach ($decoded as $key => $value) {
+                if (is_string($key)) {
+                    $result[$key] = $value;
+                    continue;
+                }
+
+                $result[(string) $key] = $value;
+            }
+
+            return $result;
         } catch (\JsonException $e) {
             throw new PlaywrightException('Response body is not valid JSON: '.$e->getMessage(), 0, $e);
         }
@@ -174,6 +188,5 @@ public function text(): string
 
     public function dispose(): void
     {
-        // No-op for now - in the future this might release resources
     }
 }

src/Assertions/AssertionOptions.php

@@ -16,16 +16,13 @@
 
 readonly class AssertionOptions
 {
-    // TODO add from/to array
-    // also allow array anywhere this type is used as argument
-
     public function __construct(
         public ?int $timeoutMs = null,
         public ?int $intervalMs = 100,
         public ?string $message = null,
-        public ?bool $strict = null,        // e.g. exact text match
-        public ?bool $ignoreCase = null,    // text assertions
-        public ?bool $useInnerText = null,  // locator text
+        public ?bool $strict = null,
+        public ?bool $ignoreCase = null,
+        public ?bool $useInnerText = null,
     ) {
     }
 }

src/Assertions/GenericAssertionsInterface.php

@@ -29,5 +29,5 @@ public function toBeFalsy(?AssertionOptions $options = null): self;
     public function toBeGreaterThan(int|float $expected, ?AssertionOptions $options = null): self;
 
     /** @return $this */
-    public function not(): self; // flips to negated mode for next assertion
+    public function not(): self;
 }

src/Assertions/Waiter.php

@@ -33,6 +33,6 @@ public static function eventually(callable $predicate, int $timeoutMs = self::DE
             \usleep($intervalMs * 1000);
         } while (\hrtime(true) < $deadline);
 
-        throw new TimeoutException('Condition not met within timeout.'); // caught & rethrown as AssertionException by callers
+        throw new TimeoutException('Condition not met within timeout.');
     }
 }

src/Browser/BrowserContext.php

@@ -517,7 +517,6 @@ public function waitForPopup(callable $action, array $options = []): PageInterfa
         if (method_exists($this->transport, 'storePendingCallback')) {
             $this->transport->storePendingCallback($requestId, $action);
         } else {
-            // Fallback for transports that don't support callbacks
             $action();
         }
 
@@ -563,7 +562,6 @@ private function validateTransportArray(mixed $data, string $context = ''): arra
 
     public function request(): APIRequestContextInterface
     {
-        // No baseURL configured at the context level by default
         return new APIRequestContext($this->transport, $this->contextId, null);
     }
 

src/Browser/BrowserContextBuilder.php

@@ -90,7 +90,6 @@ public function withRecordVideoDir(string $dir): self
 
     public function withColorScheme(string $scheme): self
     {
-        // Expected values: 'light' | 'dark' | 'no-preference'
         $this->options['colorScheme'] = $scheme;
 
         return $this;

src/Clock/Clock.php

@@ -49,7 +49,7 @@ public function pauseAt(\DateTimeInterface|int|string $time): void
     {
         $timeValue = $time;
         if ($time instanceof \DateTimeInterface) {
-            $timeValue = $time->getTimestamp() * 1000; // Convert to milliseconds
+            $timeValue = $time->getTimestamp() * 1000;
         }
 
         $this->transport->send([
@@ -80,7 +80,7 @@ public function setFixedTime(\DateTimeInterface|int|string $time): void
     {
         $timeValue = $time;
         if ($time instanceof \DateTimeInterface) {
-            $timeValue = $time->getTimestamp() * 1000; // Convert to milliseconds
+            $timeValue = $time->getTimestamp() * 1000;
         }
 
         $this->transport->send([
@@ -94,7 +94,7 @@ public function setSystemTime(\DateTimeInterface|int|string $time): void
     {
         $timeValue = $time;
         if ($time instanceof \DateTimeInterface) {
-            $timeValue = $time->getTimestamp() * 1000; // Convert to milliseconds
+            $timeValue = $time->getTimestamp() * 1000;
         }
 
         $this->transport->send([

src/Dialog/Dialog.php

@@ -16,7 +16,6 @@
 
 use Playwright\Page\PageInterface;
 
-class Dialog
 /**
  * @author Simon André <smn.andre@gmail.com>
  */

src/Download/Download.php

@@ -23,10 +23,6 @@
  * Download class for Playwright PHP.
  */
 final class Download implements DownloadInterface
-{
- * @author Simon André <smn.andre@gmail.com>
- */
-final class Download implements DownloadInterface
 {
     /**
      * @param array<string, mixed> $data
@@ -44,7 +40,6 @@ public function __construct(
     public function cancel(): void
     {
         $this->transport->send([
-            'action' => 'downloadCancel',
             'action' => 'download.cancel',
             'downloadId' => $this->downloadId,
         ]);
@@ -73,16 +68,11 @@ public function createReadStream()
         rewind($stream);
 
         return $stream;
-    public function createReadStream(): mixed
-    {
-        // TODO: Implement stream handling - PHP streams are different from Node.js Readable
-        return null;
     }
 
     public function delete(): void
     {
         $this->transport->send([
-            'action' => 'downloadDelete',
             'action' => 'download.delete',
             'downloadId' => $this->downloadId,
         ]);
@@ -95,13 +85,6 @@ public function failure(): ?string
             'downloadId' => $this->downloadId,
         ]);
 
-        $error = $response['error'] ?? null;
-
-        return is_string($error) ? $error : null;
-            'action' => 'download.failure',
-            'downloadId' => $this->downloadId,
-        ]);
-
         if (isset($response['error']) && is_string($response['error'])) {
             return $response['error'];
         }
@@ -126,24 +109,11 @@ public function path(): string
         }
 
         return $response['path'];
-    public function path(): ?string
-    {
-        $response = $this->transport->send([
-            'action' => 'download.path',
-            'downloadId' => $this->downloadId,
-        ]);
-
-        if (isset($response['path']) && is_string($response['path'])) {
-            return $response['path'];
-        }
-
-        return null;
     }
 
     public function saveAs(string $path): void
     {
         $this->transport->send([
-            'action' => 'downloadSaveAs',
             'action' => 'download.saveAs',
             'downloadId' => $this->downloadId,
             'path' => $path,
@@ -152,13 +122,23 @@ public function saveAs(string $path): void
 
     public function suggestedFilename(): string
     {
-        return $this->suggestedFilename;
-        return is_string($this->data['suggestedFilename'] ?? null) ? $this->data['suggestedFilename'] : '';
+        if ('' !== $this->suggestedFilename) {
+            return $this->suggestedFilename;
+        }
+
+        $fallback = $this->data['suggestedFilename'] ?? null;
+
+        return is_string($fallback) ? $fallback : '';
     }
 
     public function url(): string
     {
-        return $this->url;
-        return is_string($this->data['url'] ?? null) ? $this->data['url'] : '';
+        if ('' !== $this->url) {
+            return $this->url;
+        }
+
+        $fallback = $this->data['url'] ?? null;
+
+        return is_string($fallback) ? $fallback : '';
     }
 }