From 1e814ae59af358d8a7bb0e538f0450eff46cc633 Mon Sep 17 00:00:00 2001 From: Gabriel Wu <13583761+lucifer1004@users.noreply.github.com> Date: Mon, 20 Jul 2026 19:32:23 -0700 Subject: [PATCH 1/4] fix(processing): acknowledge viewed task failures --- .../architecture/document-processing.md | 5 +- docs/community/architecture/frontend.md | 6 +- web/src/lib/i18n.ts | 4 +- .../pages/processing/ProcessingTaskCenter.tsx | 41 ++++++++++-- web/src/pages/processing/model.test.ts | 46 ++++++++++++- web/src/pages/processing/model.ts | 66 +++++++++++++++++++ 6 files changed, 155 insertions(+), 13 deletions(-) diff --git a/docs/community/architecture/document-processing.md b/docs/community/architecture/document-processing.md index 78e0314..2def8f9 100644 --- a/docs/community/architecture/document-processing.md +++ b/docs/community/architecture/document-processing.md @@ -449,8 +449,9 @@ Submission remains contextual: State is centralized in a global task center opened from the application header. Desktop uses a right-side drawer; small screens use a full-screen route or -sheet. The badge counts the current user's queued and running jobs and surfaces -failed work without adding job lifecycle to the preview component. +sheet. The badge counts active jobs and surfaces failures completed since this +user last opened the center. That browser-local acknowledgement only clears the +indicator; it does not remove durable job history or artifacts. “Global” is a presentation location, not a global Job bounded context. The first view reads Document Processing summaries. Other contexts may later diff --git a/docs/community/architecture/frontend.md b/docs/community/architecture/frontend.md index f71193e..60bee54 100644 --- a/docs/community/architecture/frontend.md +++ b/docs/community/architecture/frontend.md @@ -151,8 +151,10 @@ TanStack Query owns the account-scoped job list, capability projection, and mutations. Active jobs refresh every two seconds; an open idle drawer refreshes every fifteen seconds; a closed drawer with only terminal work stops polling. Changing accounts changes the query key and closes/reset the drawer, so stale -work cannot cross an identity boundary. Component state owns only presentation -choices and transient download/cancel errors. +work cannot cross an identity boundary. An account-keyed browser timestamp +remembers which failed jobs have already been viewed; it affects only the header +indicator. Component state owns presentation choices and transient +download/cancel errors. ## Optional frontend features diff --git a/web/src/lib/i18n.ts b/web/src/lib/i18n.ts index c14155b..067e780 100644 --- a/web/src/lib/i18n.ts +++ b/web/src/lib/i18n.ts @@ -54,7 +54,7 @@ const messages: Record> = { "common.close": "Close", "processing.title": "Tasks", "processing.subtitle": "Durable builds and document conversions continue after this tab closes.", - "processing.triggerLabel": "Tasks: {active} active, {failed} failed", + "processing.triggerLabel": "Tasks: {active} active, {failed} unreviewed failures", "processing.empty": "No background tasks", "processing.emptyHint": "Background builds and conversions will appear here.", "processing.project": "Project", @@ -962,7 +962,7 @@ const messages: Record> = { "common.close": "关闭", "processing.title": "任务中心", "processing.subtitle": "持久构建与文档转换会在当前页面关闭后继续执行。", - "processing.triggerLabel": "任务:{active} 个进行中,{failed} 个失败", + "processing.triggerLabel": "任务:{active} 个进行中,{failed} 个失败待查看", "processing.empty": "暂无后台任务", "processing.emptyHint": "后台构建和文档转换会显示在这里。", "processing.project": "项目", diff --git a/web/src/pages/processing/ProcessingTaskCenter.tsx b/web/src/pages/processing/ProcessingTaskCenter.tsx index 931e572..ccc7660 100644 --- a/web/src/pages/processing/ProcessingTaskCenter.tsx +++ b/web/src/pages/processing/ProcessingTaskCenter.tsx @@ -15,12 +15,18 @@ import { import type { Translator, UiLocale } from "@/lib/i18n"; import { canCancelProcessingJob, + countUnseenProcessingFailures, isProcessingJobActive, + latestProcessingFailureCompletedAt, PROCESSING_TASK_CENTER_OPEN_EVENT, processingJobsQueryKey, - processingJobsRefetchInterval + processingJobsRefetchInterval, + readProcessingFailureSeenThrough, + writeProcessingFailureSeenThrough } from "@/pages/processing/model"; +const EMPTY_PROCESSING_JOBS: ProcessingJob[] = []; + function stateTone(job: ProcessingJob): "neutral" | "accent" | "success" | "warning" | "danger" { if (job.state === "succeeded") return "success"; if (job.state === "failed" || job.state === "expired") return "danger"; @@ -71,6 +77,10 @@ export function ProcessingTaskCenter({ const [downloadingArtifactId, setDownloadingArtifactId] = useState(null); const [openProjectError, setOpenProjectError] = useState(null); const [openingProjectId, setOpeningProjectId] = useState(null); + const [failureSeen, setFailureSeen] = useState(() => ({ + userId, + seenThrough: readProcessingFailureSeenThrough(userId) + })); const dialogRef = useRef(null); const queryKey = processingJobsQueryKey(userId); const jobsQuery = useQuery({ @@ -100,6 +110,10 @@ export function ProcessingTaskCenter({ setDownloadingArtifactId(null); setOpenProjectError(null); setOpeningProjectId(null); + setFailureSeen({ + userId, + seenThrough: readProcessingFailureSeenThrough(userId) + }); }, [userId]); useEffect(() => { @@ -143,9 +157,24 @@ export function ProcessingTaskCenter({ }; }, [open]); - const jobs = jobsQuery.data?.jobs ?? []; + const jobs = jobsQuery.data?.jobs ?? EMPTY_PROCESSING_JOBS; const activeCount = jobs.filter((job) => isProcessingJobActive(job.state)).length; - const failedCount = jobs.filter((job) => job.state === "failed").length; + const failureSeenThrough = + failureSeen.userId === userId + ? failureSeen.seenThrough + : readProcessingFailureSeenThrough(userId); + const unseenFailureCount = countUnseenProcessingFailures(jobs, failureSeenThrough); + + useEffect(() => { + if (!open || failureSeen.userId !== userId) return; + const latestFailure = latestProcessingFailureCompletedAt(jobs); + if (latestFailure <= failureSeen.seenThrough) return; + setFailureSeen({ + userId, + seenThrough: writeProcessingFailureSeenThrough(userId, latestFailure) + }); + }, [failureSeen.seenThrough, failureSeen.userId, jobs, open, userId]); + const projectNames = useMemo( () => new Map(projects.map((project) => [project.id, project.name])), [projects] @@ -156,7 +185,7 @@ export function ProcessingTaskCenter({ ); const badgeLabel = t("processing.triggerLabel", { active: activeCount, - failed: failedCount + failed: unseenFailureCount }); async function downloadArtifact(artifact: ProcessingArtifact) { @@ -197,9 +226,9 @@ export function ProcessingTaskCenter({ > - {(activeCount > 0 || failedCount > 0) && ( + {(activeCount > 0 || unseenFailureCount > 0) && ( 0 ? " has-failure" : ""}`} + className={`processing-task-count${unseenFailureCount > 0 ? " has-failure" : ""}`} aria-hidden > {activeCount > 99 ? "99+" : activeCount || "!"} diff --git a/web/src/pages/processing/model.test.ts b/web/src/pages/processing/model.test.ts index a8c7122..f61dbb5 100644 --- a/web/src/pages/processing/model.test.ts +++ b/web/src/pages/processing/model.test.ts @@ -2,11 +2,15 @@ import { describe, expect, it } from "vitest"; import type { ProcessingJob, ProcessingJobState } from "@/lib/api"; import { canCancelProcessingJob, + countUnseenProcessingFailures, isProcessingJobActive, + latestProcessingFailureCompletedAt, processingCapabilitiesQueryKey, processingJobsQueryKey, processingJobsRefetchInterval, projectProcessingCapabilitiesQueryKey, + readProcessingFailureSeenThrough, + writeProcessingFailureSeenThrough, withProcessingJob } from "@/pages/processing/model"; @@ -14,6 +18,7 @@ function job( state: ProcessingJobState, cancellationRequested = false ): ProcessingJob { + const terminal = ["succeeded", "failed", "cancelled", "expired"].includes(state); return { id: "job-1", operation: "latex.compile.pdf/v1", @@ -28,7 +33,15 @@ function job( artifacts: [], created_at: "2026-07-14T00:00:00Z", updated_at: "2026-07-14T00:00:00Z", - completed_at: state === "succeeded" ? "2026-07-14T00:00:01Z" : null + completed_at: terminal ? "2026-07-14T00:00:01Z" : null + }; +} + +function memoryStorage() { + const values = new Map(); + return { + getItem: (key: string) => values.get(key) ?? null, + setItem: (key: string, value: string) => values.set(key, value) }; } @@ -75,4 +88,35 @@ describe("processing task lifecycle", () => { other ]); }); + + it("counts only failures completed after the user last viewed tasks", () => { + const oldFailure = job("failed"); + const newFailure = { + ...job("expired"), + id: "job-2", + completed_at: "2026-07-14T00:00:02Z" + }; + const success = { + ...job("succeeded"), + id: "job-3", + completed_at: "2026-07-14T00:00:03Z" + }; + const seenThrough = Date.parse(oldFailure.completed_at!); + + expect(countUnseenProcessingFailures([oldFailure, newFailure, success], seenThrough)).toBe(1); + expect(latestProcessingFailureCompletedAt([oldFailure, newFailure, success])).toBe( + Date.parse(newFailure.completed_at) + ); + }); + + it("keeps the failure cursor account-scoped and monotonic", () => { + const storage = memoryStorage(); + + expect(writeProcessingFailureSeenThrough("user-a", 20, storage)).toBe(20); + expect(writeProcessingFailureSeenThrough("user-a", 10, storage)).toBe(20); + expect(writeProcessingFailureSeenThrough("user-a", Number.NaN, storage)).toBe(20); + expect(writeProcessingFailureSeenThrough("user-b", 5, storage)).toBe(5); + expect(readProcessingFailureSeenThrough("user-a", storage)).toBe(20); + expect(readProcessingFailureSeenThrough("user-b", storage)).toBe(5); + }); }); diff --git a/web/src/pages/processing/model.ts b/web/src/pages/processing/model.ts index 9c8e027..76da5b8 100644 --- a/web/src/pages/processing/model.ts +++ b/web/src/pages/processing/model.ts @@ -7,6 +7,10 @@ import type { Translator } from "@/lib/i18n"; export const PROCESSING_TASK_CENTER_OPEN_EVENT = "toss:processing-task-center-open"; +const PROCESSING_FAILURE_SEEN_STORAGE_PREFIX = "toss.processing.failure-seen-through."; + +type ProcessingFailureSeenStorage = Pick; + export function processingJobsQueryKey(userId: string) { return ["processing", "jobs", userId] as const; } @@ -50,6 +54,68 @@ export function isProcessingJobActive(state: ProcessingJobState) { return ["preparing", "queued", "running", "finalizing"].includes(state); } +function processingFailureCompletedAt(job: ProcessingJob) { + if (job.state !== "failed" && job.state !== "expired") return null; + const completedAt = Date.parse(job.completed_at ?? ""); + return Number.isFinite(completedAt) ? completedAt : null; +} + +export function latestProcessingFailureCompletedAt(jobs: ProcessingJob[]) { + return jobs.reduce((latest, job) => { + const completedAt = processingFailureCompletedAt(job); + return completedAt === null ? latest : Math.max(latest, completedAt); + }, 0); +} + +export function countUnseenProcessingFailures( + jobs: ProcessingJob[], + seenThrough: number +) { + return jobs.filter((job) => { + const completedAt = processingFailureCompletedAt(job); + return completedAt !== null && completedAt > seenThrough; + }).length; +} + +function processingFailureSeenStorageKey(userId: string) { + return `${PROCESSING_FAILURE_SEEN_STORAGE_PREFIX}${userId}`; +} + +export function readProcessingFailureSeenThrough( + userId: string, + storage?: ProcessingFailureSeenStorage +) { + try { + const raw = (storage ?? window.localStorage).getItem( + processingFailureSeenStorageKey(userId) + ); + if (raw === null) return 0; + const value = Number(raw); + return Number.isFinite(value) && value >= 0 ? value : 0; + } catch { + return 0; + } +} + +export function writeProcessingFailureSeenThrough( + userId: string, + seenThrough: number, + storage?: ProcessingFailureSeenStorage +) { + const value = Number.isFinite(seenThrough) && seenThrough >= 0 ? seenThrough : 0; + try { + const target = storage ?? window.localStorage; + const persisted = Math.max( + readProcessingFailureSeenThrough(userId, target), + value + ); + target.setItem(processingFailureSeenStorageKey(userId), String(persisted)); + return persisted; + } catch { + return value; + } +} + export function canCancelProcessingJob(job: ProcessingJob) { return ( !job.cancellation_requested && From 1637ccf992fc47b81f74258a40cccb46726f4c41 Mon Sep 17 00:00:00 2001 From: Gabriel Wu <13583761+lucifer1004@users.noreply.github.com> Date: Mon, 20 Jul 2026 19:45:21 -0700 Subject: [PATCH 2/4] test(web): locate the View menu exactly --- web/scripts/headless-smoke.mjs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/scripts/headless-smoke.mjs b/web/scripts/headless-smoke.mjs index 95c7c46..1a6bdba 100644 --- a/web/scripts/headless-smoke.mjs +++ b/web/scripts/headless-smoke.mjs @@ -1553,7 +1553,7 @@ try { currentStep = "mobile-settings-layout"; await pageA.setViewportSize({ width: 390, height: 844 }); await wait(300); - await pageA.getByRole("button", { name: "View" }).click(); + await pageA.getByRole("button", { name: "View", exact: true }).click(); await pageA.getByRole("menuitem", { name: "Settings" }).click(); await openSettingsStorage(pageA); await assertMobileWorkspaceLayout(pageA); From 60a1a93c49cde2a8d0e88419d3f640a0785294bd Mon Sep 17 00:00:00 2001 From: Gabriel Wu <13583761+lucifer1004@users.noreply.github.com> Date: Mon, 20 Jul 2026 19:59:52 -0700 Subject: [PATCH 3/4] test(web): make locator matching explicit --- AGENTS.md | 5 +- web/scripts/headless-ai-runtime.mjs | 2 +- web/scripts/headless-collab-git.mjs | 6 +- .../headless-full-project-load-regression.mjs | 6 +- .../headless-large-project-performance.mjs | 6 +- .../headless-preview-position-restore.mjs | 76 ------------------- .../headless-revision-collab-regression.mjs | 10 +-- web/scripts/headless-revision-panel.mjs | 10 +-- web/scripts/headless-smoke.mjs | 55 ++++++++------ .../headless-sync-cache-regression.mjs | 6 +- web/tests/e2e/collaboration-presence.spec.ts | 4 +- web/tests/e2e/external-git-settings.spec.ts | 32 ++++---- web/tests/e2e/gallery.spec.ts | 47 ++++++++---- web/tests/e2e/processing.spec.ts | 9 ++- web/tests/e2e/product-shell.spec.ts | 12 +-- web/tests/e2e/startup.spec.ts | 6 +- web/tests/e2e/typst-sync.spec.ts | 8 +- 17 files changed, 128 insertions(+), 172 deletions(-) delete mode 100644 web/scripts/headless-preview-position-restore.mjs diff --git a/AGENTS.md b/AGENTS.md index 8c4867b..7d94351 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -185,4 +185,7 @@ compatibility changes must include `npm --prefix web run test:release-resilience`, normally through that workflow. Documentation changes run `node scripts/check-docs.mjs`. Keep deterministic logic in Rust tests or Vitest and browser workflows in Playwright; all fixtures -remain synthetic and public-safe. +remain synthetic and public-safe. In Playwright, fixed accessible names and +visible text use `exact: true`; multiple accepted labels use anchored regular +expressions. Use substring matching only for intentional containment checks, +expressed explicitly through a regular expression or `hasText`. diff --git a/web/scripts/headless-ai-runtime.mjs b/web/scripts/headless-ai-runtime.mjs index d94a213..71e73fe 100644 --- a/web/scripts/headless-ai-runtime.mjs +++ b/web/scripts/headless-ai-runtime.mjs @@ -925,7 +925,7 @@ async function verifyBrowserBoundary(projectId, provider) { await page.locator('[data-action="send-prompt"]').click(); await page .getByText("Mock provider turn 8 completed.", { - exact: false + exact: true }) .waitFor({ timeout: 10_000 }); } diff --git a/web/scripts/headless-collab-git.mjs b/web/scripts/headless-collab-git.mjs index abbc7ab..5771b89 100644 --- a/web/scripts/headless-collab-git.mjs +++ b/web/scripts/headless-collab-git.mjs @@ -120,10 +120,10 @@ async function registerOrLogin(email, password, displayName) { async function login(page, email, password) { await page.goto(`${baseUrl}/signin`, { waitUntil: "domcontentloaded", timeout: 60000 }); - await page.getByPlaceholder("Email").fill(email); - await page.getByPlaceholder("Password").fill(password); + await page.getByPlaceholder("Email", { exact: true }).fill(email); + await page.getByPlaceholder("Password", { exact: true }).fill(password); await page.getByRole("button", { name: /^(Continue|Sign in)$/ }).last().click(); - await page.getByRole("heading", { name: "Projects" }).waitFor({ timeout: 30000 }); + await page.getByRole("heading", { name: "Projects", exact: true }).waitFor({ timeout: 30000 }); } async function openWorkspace(page, projectId) { diff --git a/web/scripts/headless-full-project-load-regression.mjs b/web/scripts/headless-full-project-load-regression.mjs index 6ae9606..016ecff 100644 --- a/web/scripts/headless-full-project-load-regression.mjs +++ b/web/scripts/headless-full-project-load-regression.mjs @@ -78,10 +78,10 @@ function buildLargeSvg(targetBytes, color) { async function loginUi(page, email, password) { await page.goto(`${baseUrl}/signin`, { waitUntil: "domcontentloaded", timeout: 60000 }); - await page.getByPlaceholder("Email").fill(email); - await page.getByPlaceholder("Password").fill(password); + await page.getByPlaceholder("Email", { exact: true }).fill(email); + await page.getByPlaceholder("Password", { exact: true }).fill(password); await page.getByRole("button", { name: /^(Continue|Sign in)$/ }).last().click(); - await page.getByRole("heading", { name: /Projects|项目/ }).waitFor({ timeout: 60000 }); + await page.getByRole("heading", { name: /^(Projects|项目)$/ }).waitFor({ timeout: 60000 }); } async function openWorkspace(page, projectId) { diff --git a/web/scripts/headless-large-project-performance.mjs b/web/scripts/headless-large-project-performance.mjs index dcb49c0..5d83276 100644 --- a/web/scripts/headless-large-project-performance.mjs +++ b/web/scripts/headless-large-project-performance.mjs @@ -108,10 +108,10 @@ async function ensureLargeProject(sessionToken) { async function loginUi(page) { await page.goto(`${baseUrl}/signin`, { waitUntil: "domcontentloaded", timeout: 120000 }); - await page.getByPlaceholder("Email").fill(userEmail); - await page.getByPlaceholder("Password").fill(userPassword); + await page.getByPlaceholder("Email", { exact: true }).fill(userEmail); + await page.getByPlaceholder("Password", { exact: true }).fill(userPassword); await page.getByRole("button", { name: /^(Continue|Sign in)$/ }).last().click(); - await page.getByRole("heading", { name: /Projects|项目/ }).waitFor({ timeout: 60000 }); + await page.getByRole("heading", { name: /^(Projects|项目)$/ }).waitFor({ timeout: 60000 }); } function createMetricCollector(page, cdp) { diff --git a/web/scripts/headless-preview-position-restore.mjs b/web/scripts/headless-preview-position-restore.mjs deleted file mode 100644 index 6990e61..0000000 --- a/web/scripts/headless-preview-position-restore.mjs +++ /dev/null @@ -1,76 +0,0 @@ -import { chromium } from "playwright"; - -const PROJECT_ID = "c22502ea-ef21-4765-827f-a9cfd1609286"; -const PROJECT_URL = `http://localhost:18080/project/${PROJECT_ID}`; -const SIGN_IN_URL = "http://localhost:18080/sign-in"; - -async function ensureSignedIn(page) { - await page.goto(SIGN_IN_URL, { waitUntil: "domcontentloaded" }); - const emailInput = page - .locator('input[placeholder*="Email"], input[placeholder*="邮箱"], input[name="email"], input[type="email"]') - .first(); - await emailInput.waitFor({ state: "visible", timeout: 20000 }); - await emailInput.fill("test@guozz.cn"); - await page - .locator('input[placeholder*="Password"], input[placeholder*="密码"], input[name="password"], input[type="password"]') - .first() - .fill("001gzz00"); - await page.getByRole("button", { name: /continue|继续/i }).click(); - await page.waitForTimeout(1200); - await page.goto("http://localhost:18080/projects", { waitUntil: "networkidle" }); - if (page.url().includes("/sign-in")) { - throw new Error("Sign-in failed in headless run"); - } -} - -function readStoredSettings(projectId) { - const raw = localStorage.getItem(`workspace.preview.settings.${projectId}`); - if (!raw) { - return null; - } - try { - return JSON.parse(raw); - } catch { - return null; - } -} - -async function main() { - const browser = await chromium.launch({ headless: true }); - const context = await browser.newContext({ viewport: { width: 1600, height: 1000 } }); - const page = await context.newPage(); - - await ensureSignedIn(page); - await page.goto(PROJECT_URL, { waitUntil: "networkidle" }); - await page.waitForTimeout(10000); - - const before = await page.evaluate(() => { - const frame = document.querySelector(".pdf-frame"); - if (!frame) return null; - const maxTop = Math.max(1, frame.scrollHeight - frame.clientHeight); - frame.scrollTop = Math.floor(maxTop * 0.71); - frame.scrollLeft = 0; - return { top: frame.scrollTop, maxTop, ratio: frame.scrollTop / maxTop }; - }); - - await page.waitForTimeout(1400); - const storedBefore = await page.evaluate(readStoredSettings, PROJECT_ID); - - await page.reload({ waitUntil: "networkidle" }); - await page.waitForTimeout(10000); - - const after = await page.evaluate(() => { - const frame = document.querySelector(".pdf-frame"); - if (!frame) return null; - const maxTop = Math.max(1, frame.scrollHeight - frame.clientHeight); - return { top: frame.scrollTop, maxTop, ratio: frame.scrollTop / maxTop }; - }); - const storedAfter = await page.evaluate(readStoredSettings, PROJECT_ID); - - await page.screenshot({ path: "scripts/preview-position-after-refresh.png", fullPage: true }); - console.log(JSON.stringify({ before, storedBefore, after, storedAfter }, null, 2)); - - await browser.close(); -} - -await main(); diff --git a/web/scripts/headless-revision-collab-regression.mjs b/web/scripts/headless-revision-collab-regression.mjs index 0f2d51c..1d0dadd 100644 --- a/web/scripts/headless-revision-collab-regression.mjs +++ b/web/scripts/headless-revision-collab-regression.mjs @@ -64,10 +64,10 @@ async function registerOrLogin(email, password, displayName) { async function login(page, email, password) { await page.goto(`${baseUrl}/signin`, { waitUntil: "domcontentloaded", timeout: 60000 }); - const projectsHeading = page.getByRole("heading", { name: "Projects" }); - const emailInput = page.getByPlaceholder("Email"); + const projectsHeading = page.getByRole("heading", { name: "Projects", exact: true }); + const emailInput = page.getByPlaceholder("Email", { exact: true }); await emailInput.fill(email); - await page.getByPlaceholder("Password").fill(password); + await page.getByPlaceholder("Password", { exact: true }).fill(password); await page.getByRole("button", { name: /^(Continue|Sign in)$/ }).last().click(); await projectsHeading.waitFor({ timeout: 30000 }); } @@ -134,7 +134,7 @@ async function main() { throw new Error(`expected one marker after typing; got ${count}`); } - await pageA.getByRole("button", { name: "Revisions" }).click(); + await pageA.getByRole("button", { name: "Revisions", exact: true }).click(); await pageA.locator(".history-item").first().waitFor({ timeout: 10000 }); await pageA.locator(".history-item").first().click(); await pageA.waitForFunction( @@ -146,7 +146,7 @@ async function main() { await pageA.screenshot({ path: revisionShot, fullPage: true }); artifacts.push(revisionShot); - await pageA.getByRole("button", { name: "Revisions" }).click(); + await pageA.getByRole("button", { name: "Revisions", exact: true }).click(); await pageA.waitForFunction( (needle) => (document.querySelector(".cm-content")?.textContent || "").includes(needle), marker, diff --git a/web/scripts/headless-revision-panel.mjs b/web/scripts/headless-revision-panel.mjs index 3e24d40..1381765 100644 --- a/web/scripts/headless-revision-panel.mjs +++ b/web/scripts/headless-revision-panel.mjs @@ -61,10 +61,10 @@ async function registerOrLogin(email, password, displayName) { async function login(page, email, password) { await page.goto(`${baseUrl}/signin`, { waitUntil: "domcontentloaded", timeout: 60000 }); - await page.getByPlaceholder("Email").fill(email); - await page.getByPlaceholder("Password").fill(password); + await page.getByPlaceholder("Email", { exact: true }).fill(email); + await page.getByPlaceholder("Password", { exact: true }).fill(password); await page.getByRole("button", { name: /^(Continue|Sign in)$/ }).last().click(); - await page.getByRole("heading", { name: "Projects" }).waitFor({ timeout: 30000 }); + await page.getByRole("heading", { name: "Projects", exact: true }).waitFor({ timeout: 30000 }); } async function main() { @@ -107,7 +107,7 @@ async function main() { await page.screenshot({ path: liveShot, fullPage: true }); artifacts.push(liveShot); - await page.getByRole("button", { name: "Revisions" }).click(); + await page.getByRole("button", { name: "Revisions", exact: true }).click(); await page.locator(".history-item").first().waitFor({ timeout: 10000 }); await page.locator(".history-item").nth(1).click(); await page.waitForFunction( @@ -124,7 +124,7 @@ async function main() { await page.screenshot({ path: revisionShot, fullPage: true }); artifacts.push(revisionShot); - await page.getByRole("button", { name: "Revisions" }).click(); + await page.getByRole("button", { name: "Revisions", exact: true }).click(); await page.waitForFunction( () => (document.querySelector(".cm-content")?.textContent || "").includes("Version B"), undefined, diff --git a/web/scripts/headless-smoke.mjs b/web/scripts/headless-smoke.mjs index 1a6bdba..ad6143d 100644 --- a/web/scripts/headless-smoke.mjs +++ b/web/scripts/headless-smoke.mjs @@ -98,10 +98,10 @@ async function registerOrLogin(email, password, displayName) { async function login(page, email, password) { await page.goto(`${baseUrl}/signin`, { waitUntil: "domcontentloaded", timeout: 60000 }); - await page.getByPlaceholder("Email").fill(email); - await page.getByPlaceholder("Password").fill(password); + await page.getByPlaceholder("Email", { exact: true }).fill(email); + await page.getByPlaceholder("Password", { exact: true }).fill(password); await page.getByRole("button", { name: /^(Continue|Sign in)$/ }).last().click(); - await page.getByRole("heading", { name: "Projects" }).waitFor({ timeout: 30000 }); + await page.getByRole("heading", { name: "Projects", exact: true }).waitFor({ timeout: 30000 }); await assertStandardPageLayout(page); } @@ -115,12 +115,12 @@ async function openWorkspace(page, projectId) { } async function openSettingsStorage(page) { - const storageTab = page.getByRole("tab", { name: "Storage" }); + const storageTab = page.getByRole("tab", { name: "Storage", exact: true }); await storageTab.waitFor({ timeout: 10000 }); if ((await storageTab.getAttribute("aria-selected")) !== "true") { await storageTab.click(); } - await page.getByText("Git access").waitFor({ timeout: 10000 }); + await page.getByText("Git access", { exact: true }).waitFor({ timeout: 10000 }); } async function waitForActiveFile(page, filePath, timeoutMs = 10000) { @@ -848,7 +848,7 @@ async function acceptPrompt(page, trigger, value) { await modalInput.waitFor({ timeout: 5000 }); await modalInput.fill(value); let saveButton = dialog.getByRole("button", { - name: /(Save|Create|OK|Confirm|确认|保存|创建|确定)/i + name: /^(Save|Create|OK|Confirm|确认|保存|创建|确定)$/i }); if ((await saveButton.count()) === 0) { saveButton = dialog.locator("button"); @@ -875,8 +875,8 @@ async function acceptConfirm(page, trigger, accept = true) { const dialog = page.locator(".ui-dialog").last(); if ((await dialog.count()) > 0 && (await dialog.isVisible().catch(() => false))) { const actionPattern = accept - ? /(Delete|Confirm|OK|Revoke|确认|删除|撤销|确定)/i - : /(Cancel|No|取消)/i; + ? /^(Delete|Confirm|OK|Revoke|确认|删除|撤销|确定)$/i + : /^(Cancel|No|取消)$/i; const actionButton = dialog.getByRole("button", { name: actionPattern }).last(); if ((await actionButton.count()) > 0) { await actionButton.click(); @@ -1232,10 +1232,10 @@ try { return { files, editor, preview }; }); if ((await pageA.locator(".panel-preview").count()) === 0) { - await pageA.getByRole("button", { name: "Preview" }).click(); + await pageA.getByRole("button", { name: "Preview", exact: true }).click(); } if ((await pageA.locator(".panel-files").count()) === 0) { - await pageA.getByRole("button", { name: "Files" }).click(); + await pageA.getByRole("button", { name: "Files", exact: true }).click(); } currentStep = "resize-layout"; const filesHandle = pageA.locator(".workspace-stage > .panel-resizer").first(); @@ -1417,7 +1417,7 @@ try { const fileChooserPromise = pageA.waitForEvent("filechooser"); currentStep = "upload-file"; - await pageA.getByRole("button", { name: "Upload" }).first().click(); + await pageA.getByRole("button", { name: "Upload", exact: true }).first().click(); const chooser = await fileChooserPromise; await chooser.setFiles(tempUploadFile); const uploadedFileName = path.basename(tempUploadFile); @@ -1426,7 +1426,7 @@ try { .first() .waitFor({ timeout: 10000 }); await pageA.locator(".tree-label", { hasText: uploadedFileName }).first().click(); - await pageA.getByText("Uploaded From UI").waitFor({ timeout: 10000 }); + await pageA.getByText("Uploaded From UI", { exact: true }).waitFor({ timeout: 10000 }); await openContextMenu(pageA, uploadedFileName); currentStep = "context-delete-uploaded-file"; @@ -1454,16 +1454,18 @@ try { await pageA.locator(".tree-label", { hasText: "blob.bin" }).first().click(); currentStep = "unsupported-file-preview"; - await pageA.getByText("This file is not editable in web editor. Edit offline and sync with Git.").waitFor({ - timeout: 10000 - }); + await pageA + .getByText("This file is not editable in web editor. Edit offline and sync with Git.", { + exact: true + }) + .waitFor({ timeout: 10000 }); if ((await pageA.locator(".file-icon").count()) < 1) { throw new Error("unknown file icon is not visible for unsupported file types"); } const archiveDownloadPromise = pageA.waitForEvent("download"); currentStep = "download-archive"; - await pageA.getByRole("button", { name: "Download ZIP" }).click(); + await pageA.getByRole("button", { name: "Download ZIP", exact: true }).click(); const archiveDownload = await archiveDownloadPromise; const archivePath = path.join(outDir, "archive.zip"); await archiveDownload.saveAs(archivePath); @@ -1472,7 +1474,7 @@ try { throw new Error("Archive download is unexpectedly small"); } - await pageA.getByRole("button", { name: "Settings" }).click(); + await pageA.getByRole("button", { name: "Settings", exact: true }).click(); currentStep = "open-settings"; const settingsPanelInfo = await pageA.evaluate(() => { const panel = document.querySelector(".panel-settings .panel-content"); @@ -1500,13 +1502,16 @@ try { throw new Error("entry file select has no options"); } await openSettingsStorage(pageA); - const copyButtonBefore = pageA.getByRole("button", { name: "Copy" }).first(); + const copyButtonBefore = pageA.getByRole("button", { name: "Copy", exact: true }).first(); await copyButtonBefore.click(); - await pageA.getByRole("button", { name: "Copied" }).first().waitFor({ timeout: 3000 }); + await pageA + .getByRole("button", { name: "Copied", exact: true }) + .first() + .waitFor({ timeout: 3000 }); await bearerApi("POST", `/v1/projects/${projectId}/revisions`, owner.sessionToken, { summary: "Headless UI checkpoint" }); - await pageA.getByRole("button", { name: "Revisions" }).click(); + await pageA.getByRole("button", { name: "Revisions", exact: true }).click(); currentStep = "open-revisions"; let historyCount = 0; for (let i = 0; i < 25; i += 1) { @@ -1516,7 +1521,7 @@ try { } if (historyCount < 1) { await openWorkspace(pageA, projectId); - await pageA.getByRole("button", { name: "Revisions" }).click(); + await pageA.getByRole("button", { name: "Revisions", exact: true }).click(); for (let i = 0; i < 25; i += 1) { historyCount = await pageA.locator(".history-item").count(); if (historyCount > 0) break; @@ -1542,7 +1547,7 @@ try { undefined, { timeout: 10000 } ); - await pageA.getByRole("button", { name: "Revisions" }).click(); + await pageA.getByRole("button", { name: "Revisions", exact: true }).click(); await waitForCanvas(pageA, 20000); await assertVisiblePreviewPage(pageA); @@ -1554,7 +1559,7 @@ try { await pageA.setViewportSize({ width: 390, height: 844 }); await wait(300); await pageA.getByRole("button", { name: "View", exact: true }).click(); - await pageA.getByRole("menuitem", { name: "Settings" }).click(); + await pageA.getByRole("menuitem", { name: "Settings", exact: true }).click(); await openSettingsStorage(pageA); await assertMobileWorkspaceLayout(pageA); const mobileSettingsShot = path.join(outDir, "02b-mobile-settings.png"); @@ -1563,8 +1568,8 @@ try { await pageA.setViewportSize({ width: 1620, height: 1020 }); await wait(200); - await pageA.getByRole("button", { name: "Logout" }).click(); - await pageA.getByPlaceholder("Email").waitFor({ timeout: 10000 }); + await pageA.getByRole("button", { name: "Logout", exact: true }).click(); + await pageA.getByPlaceholder("Email", { exact: true }).waitFor({ timeout: 10000 }); const shot3 = path.join(outDir, "03-logout.png"); await pageA.screenshot({ path: shot3, fullPage: true }); diff --git a/web/scripts/headless-sync-cache-regression.mjs b/web/scripts/headless-sync-cache-regression.mjs index d4d2bf3..3a154fb 100644 --- a/web/scripts/headless-sync-cache-regression.mjs +++ b/web/scripts/headless-sync-cache-regression.mjs @@ -73,10 +73,10 @@ async function registerOrLogin(email, password, displayName) { async function loginUi(page, email, password) { await page.goto(`${baseUrl}/signin`, { waitUntil: "domcontentloaded", timeout: 60000 }); - await page.getByPlaceholder("Email").fill(email); - await page.getByPlaceholder("Password").fill(password); + await page.getByPlaceholder("Email", { exact: true }).fill(email); + await page.getByPlaceholder("Password", { exact: true }).fill(password); await page.getByRole("button", { name: /^(Continue|Sign in)$/ }).last().click(); - await page.getByRole("heading", { name: /Projects|项目/ }).waitFor({ timeout: 60000 }); + await page.getByRole("heading", { name: /^(Projects|项目)$/ }).waitFor({ timeout: 60000 }); } async function openWorkspace(page, projectId) { diff --git a/web/tests/e2e/collaboration-presence.spec.ts b/web/tests/e2e/collaboration-presence.spec.ts index f82f1b7..df0e274 100644 --- a/web/tests/e2e/collaboration-presence.spec.ts +++ b/web/tests/e2e/collaboration-presence.spec.ts @@ -30,8 +30,8 @@ test("shows multiple editing sessions for one account without double-counting co }) => { const account = await createPresenceProject(request); await page.goto("/signin"); - await page.getByPlaceholder("Email").fill(account.email); - await page.getByPlaceholder("Password").fill(account.password); + await page.getByPlaceholder("Email", { exact: true }).fill(account.email); + await page.getByPlaceholder("Password", { exact: true }).fill(account.password); await page.locator(".auth-submit").click(); await expect( page.getByRole("heading", { name: "Projects", exact: true }), diff --git a/web/tests/e2e/external-git-settings.spec.ts b/web/tests/e2e/external-git-settings.spec.ts index 7be893d..3367f6f 100644 --- a/web/tests/e2e/external-git-settings.spec.ts +++ b/web/tests/e2e/external-git-settings.spec.ts @@ -28,12 +28,12 @@ async function openProjectStorage( account: { email: string; password: string; projectId: string } ) { await page.goto("/signin"); - await page.getByPlaceholder("Email").fill(account.email); - await page.getByPlaceholder("Password").fill(account.password); + await page.getByPlaceholder("Email", { exact: true }).fill(account.email); + await page.getByPlaceholder("Password", { exact: true }).fill(account.password); await page.getByRole("button", { name: "Sign in", exact: true }).last().click(); - await page.getByRole("heading", { name: "Projects" }).waitFor(); + await page.getByRole("heading", { name: "Projects", exact: true }).waitFor(); await page.goto(`/project/${account.projectId}`); - await page.getByRole("button", { name: "Settings" }).click(); + await page.getByRole("button", { name: "Settings", exact: true }).click(); await page.getByRole("tab", { name: "Storage", exact: true }).click(); } @@ -169,7 +169,9 @@ test("shows an explicit workspace-only state when external Git is not configured await expect(card).toBeVisible(); await expect(card.locator(".external-git-header-status")).toHaveAttribute("aria-label", /Workspace only/); await expect( - card.getByText("No external Git provider is configured for this deployment.") + card.getByText("No external Git provider is configured for this deployment.", { + exact: true + }) ).toBeVisible(); const screenshotPath = testInfo.outputPath("external-git-settings.png"); @@ -239,7 +241,9 @@ test("shows linked repository state and opens branch synchronization", async ({ await openProjectStorage(page, account); const card = page.locator(".external-git-card"); - await expect(card.getByText("owner/repository-backed-slides")).toBeVisible(); + await expect( + card.getByText("owner/repository-backed-slides", { exact: true }) + ).toBeVisible(); await expect(card.locator(".external-git-header-status")).toHaveAttribute( "aria-label", /Synced/ @@ -252,8 +256,8 @@ test("shows linked repository state and opens branch synchronization", async ({ path: linkedCardScreenshotPath, contentType: "image/png" }); - await card.getByRole("button", { name: "Import branch" }).click(); - const branchSelect = page.getByLabel("Source branch"); + await card.getByRole("button", { name: "Import branch", exact: true }).click(); + const branchSelect = page.getByLabel("Source branch", { exact: true }); await expect(branchSelect).toBeVisible(); await expect(branchSelect).toHaveValue("slides"); await expect(branchSelect.locator("option")).toHaveCount(2); @@ -319,20 +323,20 @@ test("loads repository creation and connection choices on demand", async ({ const card = page.locator(".external-git-card"); await card - .getByRole("button", { name: "Create GitLab repository" }) + .getByRole("button", { name: "Create GitLab repository", exact: true }) .click(); - await expect(card.getByLabel("Repository owner")).toHaveValue("7"); - await expect(card.getByLabel("Repository name")).toHaveValue( + await expect(card.getByLabel("Repository owner", { exact: true })).toHaveValue("7"); + await expect(card.getByLabel("Repository name", { exact: true })).toHaveValue( "Repository-backed Slides" ); - await expect(card.getByLabel("Repository path")).toHaveValue( + await expect(card.getByLabel("Repository path", { exact: true })).toHaveValue( "repository-backed-slides" ); await card - .getByRole("button", { name: "Connect existing repository" }) + .getByRole("button", { name: "Connect existing repository", exact: true }) .click(); - await expect(card.getByLabel("GitLab repository")).toHaveValue("101"); + await expect(card.getByLabel("GitLab repository", { exact: true })).toHaveValue("101"); await expect( card.locator(".external-git-selected-project strong") ).toHaveText("owner/existing-slides"); diff --git a/web/tests/e2e/gallery.spec.ts b/web/tests/e2e/gallery.spec.ts index 5271a6a..7789668 100644 --- a/web/tests/e2e/gallery.spec.ts +++ b/web/tests/e2e/gallery.spec.ts @@ -42,23 +42,25 @@ test("creates independent projects and manages personal templates from the Galle expect(thumbnailResponse.headers()["content-type"]).toMatch(/^image\//); await page.goto("/signin"); - await page.getByPlaceholder("Email").fill(account.email); - await page.getByPlaceholder("Password").fill(account.password); - await page.getByPlaceholder("Password").press("Enter"); + await page.getByPlaceholder("Email", { exact: true }).fill(account.email); + await page.getByPlaceholder("Password", { exact: true }).fill(account.password); + await page.getByPlaceholder("Password", { exact: true }).press("Enter"); await expect(page.getByRole("heading", { name: "Projects", exact: true })).toBeVisible(); let galleryRequests = 0; page.on("request", (browserRequest) => { if (new URL(browserRequest.url()).pathname === "/v1/templates") galleryRequests += 1; }); - await page.getByRole("link", { name: "Gallery" }).click(); - await expect(page.getByRole("heading", { name: "Template Gallery" })).toBeVisible(); + await page.getByRole("link", { name: "Gallery", exact: true }).click(); + await expect( + page.getByRole("heading", { name: "Template Gallery", exact: true }) + ).toBeVisible(); await expect(page.locator(".gallery-card").first()).toBeVisible(); expect(galleryRequests).toBe(1); - await page.getByRole("link", { name: "Projects" }).click(); + await page.getByRole("link", { name: "Projects", exact: true }).click(); await expect(page.getByRole("heading", { name: "Projects", exact: true })).toBeVisible(); - await page.getByRole("link", { name: "Gallery" }).click(); + await page.getByRole("link", { name: "Gallery", exact: true }).click(); const firstCard = page.locator(".gallery-card").first(); await expect(firstCard).toBeVisible(); await page.waitForTimeout(200); @@ -66,10 +68,13 @@ test("creates independent projects and manages personal templates from the Galle await expect(firstCard.locator(".gallery-thumbnail")).toBeVisible(); const projectName = `Gallery Project ${Date.now()}`; - await firstCard.getByRole("button", { name: "Use template" }).click(); - const createDialog = page.getByRole("dialog", { name: "Create from template" }); + await firstCard.getByRole("button", { name: "Use template", exact: true }).click(); + const createDialog = page.getByRole("dialog", { + name: "Create from template", + exact: true + }); await createDialog.getByRole("textbox").fill(projectName); - await createDialog.getByRole("button", { name: "Create project" }).click(); + await createDialog.getByRole("button", { name: "Create project", exact: true }).click(); await expect(page).toHaveURL(/\/project\/[0-9a-f-]+$/); const projectId = page.url().split("/").pop(); expect(projectId).toBeTruthy(); @@ -97,15 +102,25 @@ test("creates independent projects and manages personal templates from the Galle expect(tree.nodes).toContainEqual({ path: tree.entry_file_path, kind: "file" }); await page.goto("/gallery"); - await page.getByRole("button", { name: "Create personal template" }).click(); - const personalDialog = page.getByRole("dialog", { name: "Add a personal template" }); + await page + .getByRole("button", { name: "Create personal template", exact: true }) + .click(); + const personalDialog = page.getByRole("dialog", { + name: "Add a personal template", + exact: true + }); await expect(personalDialog.getByRole("combobox")).toHaveValue(projectId ?? ""); - await personalDialog.getByRole("button", { name: "Add to Gallery" }).click(); - await page.getByRole("button", { name: "My templates" }).click(); + await personalDialog.getByRole("button", { name: "Add to Gallery", exact: true }).click(); + await page.getByRole("button", { name: "My templates", exact: true }).click(); const personalCard = page.locator(".gallery-card", { hasText: renamedProjectName }); await expect(personalCard).toBeVisible(); - await personalCard.getByRole("button", { name: "Remove from Gallery" }).click(); - const removeDialog = page.getByRole("dialog", { name: "Remove personal template?" }); + await personalCard + .getByRole("button", { name: "Remove from Gallery", exact: true }) + .click(); + const removeDialog = page.getByRole("dialog", { + name: "Remove personal template?", + exact: true + }); await removeDialog.getByRole("button", { name: "Remove", exact: true }).click(); await expect(personalCard).toHaveCount(0); diff --git a/web/tests/e2e/processing.spec.ts b/web/tests/e2e/processing.spec.ts index b7ad1d4..7a78b93 100644 --- a/web/tests/e2e/processing.spec.ts +++ b/web/tests/e2e/processing.spec.ts @@ -72,18 +72,21 @@ test("submits a native LaTeX build and downloads it from the task center", async await signIn(page.context(), email, password); await page.goto(`/project/${project.id}`); - const buildButton = page.getByRole("button", { name: "Build PDF in background" }); + const buildButton = page.getByRole("button", { + name: "Build PDF in background", + exact: true + }); await expect(buildButton).toBeEnabled({ timeout: 30_000 }); await buildButton.click(); - const taskCenter = page.getByRole("dialog", { name: "Tasks" }); + const taskCenter = page.getByRole("dialog", { name: "Tasks", exact: true }); await expect(taskCenter).toBeVisible(); const task = taskCenter.locator(".processing-task-item").filter({ hasText: projectName }); await expect(task).toHaveCount(1); await expect(task.getByText("Succeeded", { exact: true })).toBeVisible({ timeout: 120_000 }); const downloadPromise = page.waitForEvent("download"); - await task.getByRole("button", { name: "main.pdf" }).click(); + await task.getByRole("button", { name: "main.pdf", exact: true }).click(); const download = await downloadPromise; expect(download.suggestedFilename()).toBe("main.pdf"); const stream = await download.createReadStream(); diff --git a/web/tests/e2e/product-shell.spec.ts b/web/tests/e2e/product-shell.spec.ts index aab3750..81b1956 100644 --- a/web/tests/e2e/product-shell.spec.ts +++ b/web/tests/e2e/product-shell.spec.ts @@ -49,8 +49,10 @@ test("provides a branded public entry point, help, and explicit route states", a ); await page.setViewportSize({ width: 320, height: 568 }); - await expect(page.getByRole("button", { name: "Open navigation menu" })).toBeVisible(); - await page.getByRole("button", { name: "Open navigation menu" }).click(); + await expect( + page.getByRole("button", { name: "Open navigation menu", exact: true }) + ).toBeVisible(); + await page.getByRole("button", { name: "Open navigation menu", exact: true }).click(); await expect(page.locator(".app-navigation-menu nve-menu-item").first()).toBeVisible(); const mobileHomeLayout = await page.evaluate(() => { const viewportWidth = document.documentElement.clientWidth; @@ -146,9 +148,9 @@ test("provides a branded public entry point, help, and explicit route states", a const account = await createProductShellAccount(request); await page.goto("/profile"); await expect(page).toHaveURL(/\/signin\?returnTo=%2Fprofile$/); - await page.getByPlaceholder("Email").fill(account.email); - await page.getByPlaceholder("Password").fill(account.password); - await page.getByPlaceholder("Password").press("Enter"); + await page.getByPlaceholder("Email", { exact: true }).fill(account.email); + await page.getByPlaceholder("Password", { exact: true }).fill(account.password); + await page.getByPlaceholder("Password", { exact: true }).press("Enter"); await expect(page).toHaveURL(/\/profile$/); await expect(page.getByRole("heading", { name: "Profile Security", exact: true })).toBeVisible(); diff --git a/web/tests/e2e/startup.spec.ts b/web/tests/e2e/startup.spec.ts index 86ddb76..af2b715 100644 --- a/web/tests/e2e/startup.spec.ts +++ b/web/tests/e2e/startup.spec.ts @@ -128,9 +128,9 @@ test("keeps the project home independent from editor and Typst runtime downloads }); await page.goto("/signin"); - await page.getByPlaceholder("Email").fill(account.email); - await page.getByPlaceholder("Password").fill(account.password); - await page.getByPlaceholder("Password").press("Enter"); + await page.getByPlaceholder("Email", { exact: true }).fill(account.email); + await page.getByPlaceholder("Password", { exact: true }).fill(account.password); + await page.getByPlaceholder("Password", { exact: true }).press("Enter"); await expect(page.getByRole("heading", { name: "Projects", exact: true })).toBeVisible(); await page.waitForTimeout(750); diff --git a/web/tests/e2e/typst-sync.spec.ts b/web/tests/e2e/typst-sync.spec.ts index 5a8e6c2..bb412d9 100644 --- a/web/tests/e2e/typst-sync.spec.ts +++ b/web/tests/e2e/typst-sync.spec.ts @@ -113,9 +113,9 @@ test("synchronizes source and canvas positions without PDF export invalidating t }) => { const account = await createSyncProject(request); await page.goto("/signin"); - await page.getByPlaceholder("Email").fill(account.email); - await page.getByPlaceholder("Password").fill(account.password); - await page.getByPlaceholder("Password").press("Enter"); + await page.getByPlaceholder("Email", { exact: true }).fill(account.email); + await page.getByPlaceholder("Password", { exact: true }).fill(account.password); + await page.getByPlaceholder("Password", { exact: true }).press("Enter"); await expect(page.getByRole("heading", { name: "Projects", exact: true })).toBeVisible(); let compilerRequestSeen = false; await page.route("**/typst-runtime/**/typst_ts_web_compiler_bg.wasm", async (route) => { @@ -152,7 +152,7 @@ test("synchronizes source and canvas positions without PDF export invalidating t await expect(page.locator(".cm-activeLine")).toContainText("SYNC-SECOND"); const downloadPromise = page.waitForEvent("download"); - await page.getByRole("button", { name: "Download PDF" }).click(); + await page.getByRole("button", { name: "Download PDF", exact: true }).click(); const download = await downloadPromise; expect(download.suggestedFilename()).toMatch(/\.pdf$/i); From ee787112534a750185a6a207cfaa347e95e5f6cb Mon Sep 17 00:00:00 2001 From: Gabriel Wu <13583761+lucifer1004@users.noreply.github.com> Date: Mon, 20 Jul 2026 20:05:38 -0700 Subject: [PATCH 4/4] test(web): make containment locators explicit --- web/scripts/headless-ai-runtime.mjs | 4 +--- web/scripts/headless-smoke.mjs | 5 ++++- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/web/scripts/headless-ai-runtime.mjs b/web/scripts/headless-ai-runtime.mjs index 71e73fe..735063c 100644 --- a/web/scripts/headless-ai-runtime.mjs +++ b/web/scripts/headless-ai-runtime.mjs @@ -924,9 +924,7 @@ async function verifyBrowserBoundary(projectId, provider) { await page.locator('.ai-composer [name="prompt"]').fill("Verify locale propagation."); await page.locator('[data-action="send-prompt"]').click(); await page - .getByText("Mock provider turn 8 completed.", { - exact: true - }) + .getByText(/Mock provider turn 8 completed\./) .waitFor({ timeout: 10_000 }); } diff --git a/web/scripts/headless-smoke.mjs b/web/scripts/headless-smoke.mjs index ad6143d..26e2fad 100644 --- a/web/scripts/headless-smoke.mjs +++ b/web/scripts/headless-smoke.mjs @@ -1426,7 +1426,10 @@ try { .first() .waitFor({ timeout: 10000 }); await pageA.locator(".tree-label", { hasText: uploadedFileName }).first().click(); - await pageA.getByText("Uploaded From UI", { exact: true }).waitFor({ timeout: 10000 }); + await pageA + .locator(".cm-content") + .filter({ hasText: "Uploaded From UI" }) + .waitFor({ timeout: 10000 }); await openContextMenu(pageA, uploadedFileName); currentStep = "context-delete-uploaded-file";