From dfa6055425e7064003bce8fe4517af62183e6eec Mon Sep 17 00:00:00 2001 From: Claude Date: Fri, 7 Aug 2026 19:42:29 +0000 Subject: [PATCH] Trim version lookup in PMM-T2227 tarball upgrade test The docker-hub tag lookup kept its trailing newline, so the assertion on the installed client asked for "3.9.0\n" instead of "3.9.0". That only ever matched while the released tarball reported a bare version: the tarball now served for 3.9.0 reports 3.9.0-v3-83cf42bbe, so the version number is no longer at end of line and the check fails every night -- masked in CI because the test is quarantined in Launchable and the test step is run with '|| true'. Trim it, matching the latestVersion lookup a few lines below, so the assertion checks that the output contains the version number and the value interpolated into the install command carries no stray newline. Signed-off-by: Claude --- cli/tests/generic.spec.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cli/tests/generic.spec.ts b/cli/tests/generic.spec.ts index d7608d795..b956c9720 100644 --- a/cli/tests/generic.spec.ts +++ b/cli/tests/generic.spec.ts @@ -573,7 +573,7 @@ test.describe('PMM Client "Generic" CLI tests', { tag: '@generic' }, async () => await cli.exec('docker network create pmm-qa || true'); await cli.exec('docker network connect pmm-server pmm-qa'); await cli.exec(`docker run --rm -d --name="${containerName}" --network="pmm-qa" --privileged --cgroupns=host -v /sys/fs/cgroup:/sys/fs/cgroup:rw -v /var/lib/containerd antmelekhin/docker-systemd:almalinux-10`); - const latestReleasedVersion = (await cli.exec('wget -q https://registry.hub.docker.com/v2/repositories/percona/pmm-client/tags -O - | jq -r .results[].name | grep -v latest | sort -V | tail -n1')).stdout; + const latestReleasedVersion = (await cli.exec('wget -q https://registry.hub.docker.com/v2/repositories/percona/pmm-client/tags -O - | jq -r .results[].name | grep -v latest | sort -V | tail -n1')).stdout.trim(); await cli.exec(`docker cp ../package_tests/scripts/pmm3_client_install_tarball.sh ${containerName}:/`); await cli.exec(`docker exec ${containerName} dnf install -y wget`); await cli.exec(`docker exec ${containerName} /pmm3_client_install_tarball.sh -v ${latestReleasedVersion}`);