diff --git a/m1/e2e-benchmark/src/main.rs b/m1/e2e-benchmark/src/main.rs index 5b35c21d..27a7b16e 100644 --- a/m1/e2e-benchmark/src/main.rs +++ b/m1/e2e-benchmark/src/main.rs @@ -179,19 +179,19 @@ impl Statistics { .iter() .filter(|&&(time, _)| time >= current_time && time < window_end) .count(); - let sucess_count = self + let success_count = self .records .iter() .filter(|&&(time, success)| time >= current_time && time < window_end && success) .count(); - let failure_count = total_count - sucess_count; + let failure_count = total_count - success_count; writeln!( file, "{},{},{},{}", current_time.elapsed().as_secs_f64(), total_count, - sucess_count, + success_count, failure_count )?; current_time += Duration::from_secs(WINDOW_SIZE.clone()); diff --git a/m1/subnet/src/vm/mod.rs b/m1/subnet/src/vm/mod.rs index 584b4d26..ce9e826c 100644 --- a/m1/subnet/src/vm/mod.rs +++ b/m1/subnet/src/vm/mod.rs @@ -1105,7 +1105,7 @@ impl BatchedChainVm for Vm { _block_id: ids::Id, _max_block_num: i32, _max_block_size: i32, - _max_block_retrival_time: Duration, + _max_block_retrieval_time: Duration, ) -> io::Result> { Err(Error::new( ErrorKind::Unsupported, diff --git a/movement-sdk/clis/aptos/e2e/cases/init.py b/movement-sdk/clis/aptos/e2e/cases/init.py index 0ab32c8b..0b98d579 100644 --- a/movement-sdk/clis/aptos/e2e/cases/init.py +++ b/movement-sdk/clis/aptos/e2e/cases/init.py @@ -10,7 +10,7 @@ @test_case def test_init(run_helper: RunHelper, test_name=None): - # Inititalize a profile for the CLI to use. Note that we do not set the + # Initialize a profile for the CLI to use. Note that we do not set the # --skip-faucet flag. This means that in addition to creating a profile locally, # it will use the faucet to create the account on chain. This will fund the # account with the default amount of 100000000 OCTA. diff --git a/movement-sdk/clis/aptos/src/common/types.rs b/movement-sdk/clis/aptos/src/common/types.rs index bbaf52b0..024a5adb 100644 --- a/movement-sdk/clis/aptos/src/common/types.rs +++ b/movement-sdk/clis/aptos/src/common/types.rs @@ -1623,10 +1623,10 @@ impl TransactionOptions { gas_unit_price: Some(gas_unit_price), pending: None, sender: Some(sender_address), - sequence_number: None, // The transaction is not comitted so there is no new sequence number. + sequence_number: None, // The transaction is not committed so there is no new sequence number. success, timestamp_us: None, - version: Some(version), // The transaction is not comitted so there is no new version. + version: Some(version), // The transaction is not committed so there is no new version. vm_status: Some(vm_status.to_string()), }) } diff --git a/movement-sdk/clis/aptos/src/node/analyze/analyze_validators.rs b/movement-sdk/clis/aptos/src/node/analyze/analyze_validators.rs index a5fa20b1..9ffb343b 100644 --- a/movement-sdk/clis/aptos/src/node/analyze/analyze_validators.rs +++ b/movement-sdk/clis/aptos/src/node/analyze/analyze_validators.rs @@ -225,11 +225,11 @@ impl AnalyzeValidators { version: raw_event.transaction_version, sequence_number: raw_event.event.sequence_number(), }); - }, + } Ordering::Greater => { return Ok(result); - }, - Ordering::Less => {}, + } + Ordering::Less => {} }; } } @@ -280,7 +280,7 @@ impl AnalyzeValidators { previous_round + u64::from(!is_nil) + event.failed_proposer_indices().len() as u64; if event.round() != expected_round { println!( - "Missing failed AccountAddresss : {} {:?}", + "Missing failed AccountAddress : {} {:?}", previous_round, &event ); assert!(expected_round < event.round()); @@ -344,13 +344,16 @@ impl AnalyzeValidators { validator_stats: validators .iter() .map(|validator| { - (validator.address, ValidatorStats { - proposal_successes: *successes.get(&validator.address).unwrap_or(&0), - proposal_failures: *failures.get(&validator.address).unwrap_or(&0), - votes: *votes.get(&validator.address).unwrap_or(&0), - transactions: *transactions.get(&validator.address).unwrap_or(&0), - voting_power: validator.voting_power, - }) + ( + validator.address, + ValidatorStats { + proposal_successes: *successes.get(&validator.address).unwrap_or(&0), + proposal_failures: *failures.get(&validator.address).unwrap_or(&0), + votes: *votes.get(&validator.address).unwrap_or(&0), + transactions: *transactions.get(&validator.address).unwrap_or(&0), + voting_power: validator.voting_power, + }, + ) }) .collect(), total_rounds, @@ -382,7 +385,7 @@ impl AnalyzeValidators { "elected", "% rounds", "% failed", - "succeded", + "succeeded", "failed", "voted", "transact", diff --git a/movement-sdk/clis/aptos/src/node/analyze/fetch_metadata.rs b/movement-sdk/clis/aptos/src/node/analyze/fetch_metadata.rs index e9ab24e8..91a132a0 100644 --- a/movement-sdk/clis/aptos/src/node/analyze/fetch_metadata.rs +++ b/movement-sdk/clis/aptos/src/node/analyze/fetch_metadata.rs @@ -160,7 +160,7 @@ impl FetchMetadata { let oldest_fetchable_epoch = std::cmp::max(oldest_event.event.epoch() + 1, 2); if oldest_fetchable_epoch > wanted_start_epoch as u64 { println!( - "Oldest full epoch that can be retreived is {} ", + "Oldest full epoch that can be retrieved is {} ", oldest_fetchable_epoch ); oldest_fetchable_epoch diff --git a/movement-sdk/clis/aptos/src/op/key.rs b/movement-sdk/clis/aptos/src/op/key.rs index aac2d31f..9827d81b 100644 --- a/movement-sdk/clis/aptos/src/op/key.rs +++ b/movement-sdk/clis/aptos/src/op/key.rs @@ -370,7 +370,7 @@ impl SaveKey { .encoding_options .encoding .encode_key(key_name, &key.public_key())?; - let encoded_proof_of_posession = self + let encoded_proof_of_possession = self .encoding_options .encoding .encode_key(key_name, &bls12381::ProofOfPossession::create(key))?; @@ -384,7 +384,7 @@ impl SaveKey { write_to_file( &proof_of_possession_file, key_name, - &encoded_proof_of_posession, + &encoded_proof_of_possession, )?; let mut map = HashMap::new(); diff --git a/movement-sdk/clis/aptos/src/stake/mod.rs b/movement-sdk/clis/aptos/src/stake/mod.rs index 45168a70..46006b89 100644 --- a/movement-sdk/clis/aptos/src/stake/mod.rs +++ b/movement-sdk/clis/aptos/src/stake/mod.rs @@ -346,7 +346,7 @@ impl CliCommand for InitializeStakeOwner { /// Delegate operator capability to another account /// -/// This changes teh operator capability from its current operator to a different operator. +/// This changes the operator capability from its current operator to a different operator. /// By default, the operator of a stake pool is the owner of the stake pool #[derive(Parser)] pub struct SetOperator { diff --git a/movement-sdk/clis/aptos/src/update/tool.rs b/movement-sdk/clis/aptos/src/update/tool.rs index 1528ff85..06f35019 100644 --- a/movement-sdk/clis/aptos/src/update/tool.rs +++ b/movement-sdk/clis/aptos/src/update/tool.rs @@ -24,7 +24,7 @@ pub struct UpdateTool { repo_owner: String, /// The name of the repo to download the binary from. - #[clap(long, default_value = "subnet")] // TODO: update CI/CD to include this binar release in GitHub workflows + #[clap(long, default_value = "subnet")] // TODO: update CI/CD to include this binary release in GitHub workflows repo_name: String, } diff --git a/movement-sdk/execution/sui-block-executor/README.md b/movement-sdk/execution/sui-block-executor/README.md index 1fc014e4..41f4196b 100644 --- a/movement-sdk/execution/sui-block-executor/README.md +++ b/movement-sdk/execution/sui-block-executor/README.md @@ -16,7 +16,7 @@ A [`VerifiedExecutableTransaction`](https://github.com/MystenLabs/sui/blob/55215 - `SenderSignedData` which constitutes the actual transactions in a programmable transaction block sent by the user. - `CertificateEnvelope` which certifies that a transaction belongs in a given epoch. -Obtaining a `CertificateEnvelope` in an agnostic manner is part of the responsibility of the `sui-block-executor`. In the skeleton, you will see that there is a dependency on a `Box` which is responsible for providing the `CertificateEnvelope` for a given `SenderSignedData`. +Obtaining a `CertificateEnvelope` in an agnostic manner is part of the responsibility of the `sui-block-executor`. In the skeleton, you will see that there is a dependency on a `Box` which is responsible for providing the `CertificateEnvelope` for a given `SenderSignedData`. That being said, in the proof concept phase, we will mainly rely on simply transforming `Vec` into `Vec` by certifying each `SenderSignedData` with a `CertificateEnvelope` indicating a system transaction. diff --git a/movement-sdk/types/sui-helper-types/src/providers/object_version.rs b/movement-sdk/types/sui-helper-types/src/providers/object_version.rs index f6aa5635..f0dd5694 100644 --- a/movement-sdk/types/sui-helper-types/src/providers/object_version.rs +++ b/movement-sdk/types/sui-helper-types/src/providers/object_version.rs @@ -4,7 +4,7 @@ use crate::block::VerifiedExecutableExecutionGroups; #[async_trait::async_trait] pub trait ObjectVersionProvider { - /// Assignes sequence numbers to objects in the transactions + /// Assigns sequence numbers to objects in the transactions async fn assign_shared_object_versions(&self, transactions : VerifiedExecutableExecutionGroups) -> Result; } \ No newline at end of file