Should pyright warn when if "xxx" is always true?

[Alexey Dmitriev (AlexeyDmitriev)]

def f(path: Path):
    if path is not None:  # this code correctly warns that condition is always True, which is useful
        return True

def f(path: Path):
    if path: #However, this doesn't despite path that it always is true as well. I think it would also be usefull
        return True

and pyright already knows it, because it greys out false branch in

def f(path: Path):
    if path:
        return True
    else:
        return False

[Eric Traut (erictraut)]

The reportUnnecessaryComparison check specifically looks at binary operations that contain comparison operators ==, !=, is and is not. Since there is no such operator in your second example, it doesn't apply in that case.

[Alexey Dmitriev (AlexeyDmitriev)]

Yeah, I imagined (now you confirmed) that it's probably as expected. I guess my question should be rephrased as "should we also include unary bool/not operators in this list?".