Pyright returning two records for the same line

[Tanner Wilcox (twiclo)]

I'm running pyright in neovim. The latest version. When I run "go to definition" on self.reply it returns two results to the same line

class BaseRpcServer(BaseConsumer):
    def __init__(self, channel: Channel, config: "Optional[EnvConfig]"=None):
        super().__init__(channel, config)

    async def _consume(self, message: IncomingMessage) -> None:
        if message.reply_to is not None:
            try:
                res = await self.consume_rpc(message)
                await self.reply({"error": None, "res": res}, message)
            except Exception as e:
                log.error(str(e))
                await self.reply(
                    {"error": f"{str(e)}\n{traceback.format_exc()}", "res": None}, message
                )
        else:
            await self.consume(message)

    # Commented out so I don't have to update everything yet
    # @abstractmethod
    async def consume_rpc(self, message: IncomingMessage) -> Any:
        pass

    async def reply(self, body: Union[str, bytes], message: IncomingMessage):
        if isinstance(body, Dict):

Any ideas would be appreciated

[Eric Traut (erictraut)]

The code sample you've provided references a bunch of symbols that are not defined, so it's difficult to provide a specific answer. However, it's not uncommon for "go to definition" to return multiple results. For example, a symbol could represent a property that has both a getter and a setter. Or it could be a function with multiple overloads. The language server protocol calls for a language server to return all declarations that correspond to the symbol.

[Eric Traut (erictraut)]

Ah, looks like it's returning the same definition twice. VS Code deduplicates, so it's possible there's a bug here that has gone undetected and doesn't matter for most editors.

The language server features in pyright are owned by the pylance team. If you'd like them to take a look at this, please file a bug report in the pylance/release project.

[Tanner Wilcox (twiclo)]

Just to confirm it's pyright/pylance and not neovim or my config is there a way I can run the definition command through my terminal?

[Eric Traut (erictraut)]

You can instantiate, initialize and then call the language server manually, but you'd need to write quite a bit of code to do this.

I just tried it in the pyright VS Code extension with a debugger attached, and I'm seeing only one definition returned from the LSP. That seems to support the theory that it's a problem in neovim, not in the pyright LSP.

[Tanner Wilcox (twiclo)]

I found this issue about duplicates with references. Looks like it was fixed. Maybe this is a similar issue with definitions?

[Alex Kerkum (acidtv)]

This was fixed for me after upgrading to Neovim 0.11.3.