Repository navigation
Commit 2dd0307
FBFetchFromManifest: build fetched dependencies without warnings
Summary:
A project that fetches its dependencies with `fb_fetch_from_manifest()` compiles them with its own flags, so it prints every warning they have. Most of the EdenFS Linux GitHub workflow's 81,000-line Build step is warnings in fbthrift's, fb303's, wangle's, fizz's and edencommon's sources, about 2,200 of them with their notes. Fixing them is outside the scope of eden's open source build, and they bury eden's own warnings. Each dependency's own builds still report them:
https://github.com/meta/sapling/actions/runs/41234051864
This builds a fetched dependency with `-w`, so it prints no more than an installed copy would. MSVC would warn about `/w` overriding the dependency's own `/W` level, so this leaves MSVC builds alone. Eden's own warnings, including those in the dependencies' headers it includes, are unchanged.
___
landed-with-radar-review
Differential Revision: D128861329
fbshipit-source-id: 7e629e26f3c6722036fe34380de3f3402e2602431 parent 02ba9dd commit 2dd0307
1 file changed
Lines changed: 6 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
138 | 138 | | |
139 | 139 | | |
140 | 140 | | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
141 | 147 | | |
142 | 148 | | |
143 | 149 | | |
| |||
0 commit comments