From e56c924c737c9f59c1ba09514ba635012b764857 Mon Sep 17 00:00:00 2001 From: Abderrahmane Smimite Date: Thu, 7 May 2026 17:42:50 +0200 Subject: [PATCH 1/2] fix(ci): pin pnpm via pnpm/action-setup@v4 and harden playwright version detection --- .github/workflows/frontend-coverage.yaml | 10 +++---- .github/workflows/frontend-linters.yaml | 20 ++++++------- .github/workflows/frontend-unit-tests.yml | 10 +++---- .github/workflows/functional-tests.yml | 34 ++++++++++++++++------- .github/workflows/rpm-build.yml | 8 ++++-- .github/workflows/startup-tests.yml | 16 +++++++---- 6 files changed, 56 insertions(+), 42 deletions(-) diff --git a/.github/workflows/frontend-coverage.yaml b/.github/workflows/frontend-coverage.yaml index 70429b41a9..ada6fac6b4 100644 --- a/.github/workflows/frontend-coverage.yaml +++ b/.github/workflows/frontend-coverage.yaml @@ -36,12 +36,10 @@ jobs: uses: actions/setup-node@v4 with: node-version: ${{ matrix.node-version }} - - name: Install latest pnpm - working-directory: ${{env.working-directory}} - run: | - npm install -g pnpm && - pnpm --version && - pnpm list -g --depth 0 + - name: Install pnpm + uses: pnpm/action-setup@v4 + with: + version: 10 - name: Install dependencies working-directory: ${{env.working-directory}} run: pnpm i --frozen-lockfile diff --git a/.github/workflows/frontend-linters.yaml b/.github/workflows/frontend-linters.yaml index e8fcf180b1..fa8ed2f752 100644 --- a/.github/workflows/frontend-linters.yaml +++ b/.github/workflows/frontend-linters.yaml @@ -35,12 +35,10 @@ jobs: uses: actions/setup-node@v4 with: node-version: ${{ matrix.node-version }} - - name: Install latest pnpm - working-directory: ${{env.working-directory}} - run: | - npm install -g pnpm && - pnpm --version && - pnpm list -g --depth 0 + - name: Install pnpm + uses: pnpm/action-setup@v4 + with: + version: 10 - name: Install prettier working-directory: ${{env.working-directory}} run: pnpm add --save-dev prettier @@ -74,12 +72,10 @@ jobs: uses: actions/setup-node@v4 with: node-version: ${{ matrix.node-version }} - - name: Install latest pnpm - working-directory: ${{env.working-directory}} - run: | - npm install -g pnpm && - pnpm --version && - pnpm list -g --depth 0 + - name: Install pnpm + uses: pnpm/action-setup@v4 + with: + version: 10 - name: Install prettier working-directory: ${{env.working-directory}} run: pnpm add --save-dev prettier diff --git a/.github/workflows/frontend-unit-tests.yml b/.github/workflows/frontend-unit-tests.yml index 66497aeb95..7c390dbb0b 100644 --- a/.github/workflows/frontend-unit-tests.yml +++ b/.github/workflows/frontend-unit-tests.yml @@ -35,12 +35,10 @@ jobs: uses: actions/setup-node@v4 with: node-version: ${{ matrix.node-version }} - - name: Install latest pnpm - working-directory: ${{env.working-directory}} - run: | - npm install -g pnpm && - pnpm --version && - pnpm list -g --depth 0 + - name: Install pnpm + uses: pnpm/action-setup@v4 + with: + version: 10 - name: Install dependencies working-directory: ${{env.working-directory}} run: pnpm i --frozen-lockfile diff --git a/.github/workflows/functional-tests.yml b/.github/workflows/functional-tests.yml index c1c067b4e5..2961bafbdd 100644 --- a/.github/workflows/functional-tests.yml +++ b/.github/workflows/functional-tests.yml @@ -50,8 +50,10 @@ jobs: restore-keys: | ${{ runner.os }}-pnpm- - - name: Install pnpm globally - run: npm install -g pnpm + - name: Install pnpm + uses: pnpm/action-setup@v4 + with: + version: 10 - name: Install community frontend dependencies working-directory: ${{ env.frontend-directory }} @@ -94,8 +96,10 @@ jobs: restore-keys: | ${{ runner.os }}-pnpm- - - name: Install pnpm globally - run: npm install -g pnpm + - name: Install pnpm + uses: pnpm/action-setup@v4 + with: + version: 10 - name: Build enterprise frontend working-directory: ${{ env.enterprise-frontend-directory }} @@ -238,8 +242,10 @@ jobs: restore-keys: | ${{ runner.os }}-pnpm- - - name: Install pnpm globally - run: npm install -g pnpm + - name: Install pnpm + uses: pnpm/action-setup@v4 + with: + version: 10 - name: Install community frontend dependencies (if not cached/part of build artifact) working-directory: ${{ env.frontend-directory }} @@ -247,7 +253,10 @@ jobs: - name: Get installed Playwright version id: playwright-version - run: echo "PLAYWRIGHT_VERSION=$(pnpm exec playwright --version | awk -F ' ' '{print $2}')" >> $GITHUB_ENV + working-directory: ${{ env.frontend-directory }} + run: | + PLAYWRIGHT_VERSION=$(node -p "require('@playwright/test/package.json').version") + echo "PLAYWRIGHT_VERSION=$PLAYWRIGHT_VERSION" >> "$GITHUB_ENV" - name: Cache playwright binaries uses: actions/cache@v4 @@ -414,8 +423,10 @@ jobs: working-directory: ${{ env.enterprise-frontend-directory }} run: make pre-build - - name: Install pnpm globally - run: npm install -g pnpm + - name: Install pnpm + uses: pnpm/action-setup@v4 + with: + version: 10 - name: Install enterprise frontend dependencies working-directory: ${{ env.enterprise-frontend-build-directory }} @@ -423,7 +434,10 @@ jobs: - name: Get installed Playwright version id: playwright-version - run: echo "PLAYWRIGHT_VERSION=$(pnpm exec playwright --version | awk -F ' ' '{print $2}')" >> $GITHUB_ENV + working-directory: ${{ env.enterprise-frontend-build-directory }} + run: | + PLAYWRIGHT_VERSION=$(node -p "require('@playwright/test/package.json').version") + echo "PLAYWRIGHT_VERSION=$PLAYWRIGHT_VERSION" >> "$GITHUB_ENV" - name: Cache playwright binaries uses: actions/cache@v4 diff --git a/.github/workflows/rpm-build.yml b/.github/workflows/rpm-build.yml index 0e6b9ba606..2d9404df53 100644 --- a/.github/workflows/rpm-build.yml +++ b/.github/workflows/rpm-build.yml @@ -54,11 +54,15 @@ jobs: ncurses-devel \ gdbm-devel - - name: Install Node.js and pnpm + - name: Install Node.js run: | curl -fsSL https://rpm.nodesource.com/setup_22.x | bash - dnf install -y nodejs - npm install -g pnpm + + - name: Install pnpm + uses: pnpm/action-setup@v4 + with: + version: 10 - name: Install Poetry run: | diff --git a/.github/workflows/startup-tests.yml b/.github/workflows/startup-tests.yml index a461dfc68f..5320fbeb04 100644 --- a/.github/workflows/startup-tests.yml +++ b/.github/workflows/startup-tests.yml @@ -80,11 +80,13 @@ jobs: - name: Install backend requirements working-directory: ${{ env.backend-directory }} run: poetry install + - name: Install pnpm + uses: pnpm/action-setup@v4 + with: + version: 10 - name: Install frontend dependencies working-directory: ${{ env.frontend-directory }} - run: | - npm install -g pnpm - pnpm i --frozen-lockfile + run: pnpm i --frozen-lockfile - name: Install Playwright Browsers working-directory: ${{ env.frontend-directory }} run: pnpm exec playwright install @@ -131,11 +133,13 @@ jobs: - uses: actions/setup-node@v4 with: node-version: lts/* + - name: Install pnpm + uses: pnpm/action-setup@v4 + with: + version: 10 - name: Install frontend dependencies working-directory: ${{ env.frontend-directory }} - run: | - npm install -g pnpm - pnpm i --frozen-lockfile + run: pnpm i --frozen-lockfile - name: Install Playwright Browsers working-directory: ${{ env.frontend-directory }} run: pnpm exec playwright install From bf976940c56ed5dfe4143bfd4f179492f21db272 Mon Sep 17 00:00:00 2001 From: Abderrahmane Smimite Date: Thu, 7 May 2026 18:40:45 +0200 Subject: [PATCH 2/2] use v5 for deprecation warning (we'll move to 6 soon) --- .github/workflows/frontend-coverage.yaml | 2 +- .github/workflows/frontend-linters.yaml | 4 ++-- .github/workflows/frontend-unit-tests.yml | 2 +- .github/workflows/functional-tests.yml | 8 ++++---- .github/workflows/rpm-build.yml | 2 +- .github/workflows/startup-tests.yml | 4 ++-- 6 files changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/workflows/frontend-coverage.yaml b/.github/workflows/frontend-coverage.yaml index ada6fac6b4..b1d65b15f2 100644 --- a/.github/workflows/frontend-coverage.yaml +++ b/.github/workflows/frontend-coverage.yaml @@ -37,7 +37,7 @@ jobs: with: node-version: ${{ matrix.node-version }} - name: Install pnpm - uses: pnpm/action-setup@v4 + uses: pnpm/action-setup@v5 with: version: 10 - name: Install dependencies diff --git a/.github/workflows/frontend-linters.yaml b/.github/workflows/frontend-linters.yaml index fa8ed2f752..10dc1ab1b9 100644 --- a/.github/workflows/frontend-linters.yaml +++ b/.github/workflows/frontend-linters.yaml @@ -36,7 +36,7 @@ jobs: with: node-version: ${{ matrix.node-version }} - name: Install pnpm - uses: pnpm/action-setup@v4 + uses: pnpm/action-setup@v5 with: version: 10 - name: Install prettier @@ -73,7 +73,7 @@ jobs: with: node-version: ${{ matrix.node-version }} - name: Install pnpm - uses: pnpm/action-setup@v4 + uses: pnpm/action-setup@v5 with: version: 10 - name: Install prettier diff --git a/.github/workflows/frontend-unit-tests.yml b/.github/workflows/frontend-unit-tests.yml index 7c390dbb0b..9c3a8acaaf 100644 --- a/.github/workflows/frontend-unit-tests.yml +++ b/.github/workflows/frontend-unit-tests.yml @@ -36,7 +36,7 @@ jobs: with: node-version: ${{ matrix.node-version }} - name: Install pnpm - uses: pnpm/action-setup@v4 + uses: pnpm/action-setup@v5 with: version: 10 - name: Install dependencies diff --git a/.github/workflows/functional-tests.yml b/.github/workflows/functional-tests.yml index 2961bafbdd..f2b36b4bac 100644 --- a/.github/workflows/functional-tests.yml +++ b/.github/workflows/functional-tests.yml @@ -51,7 +51,7 @@ jobs: ${{ runner.os }}-pnpm- - name: Install pnpm - uses: pnpm/action-setup@v4 + uses: pnpm/action-setup@v5 with: version: 10 @@ -97,7 +97,7 @@ jobs: ${{ runner.os }}-pnpm- - name: Install pnpm - uses: pnpm/action-setup@v4 + uses: pnpm/action-setup@v5 with: version: 10 @@ -243,7 +243,7 @@ jobs: ${{ runner.os }}-pnpm- - name: Install pnpm - uses: pnpm/action-setup@v4 + uses: pnpm/action-setup@v5 with: version: 10 @@ -424,7 +424,7 @@ jobs: run: make pre-build - name: Install pnpm - uses: pnpm/action-setup@v4 + uses: pnpm/action-setup@v5 with: version: 10 diff --git a/.github/workflows/rpm-build.yml b/.github/workflows/rpm-build.yml index 2d9404df53..7a4beb8815 100644 --- a/.github/workflows/rpm-build.yml +++ b/.github/workflows/rpm-build.yml @@ -60,7 +60,7 @@ jobs: dnf install -y nodejs - name: Install pnpm - uses: pnpm/action-setup@v4 + uses: pnpm/action-setup@v5 with: version: 10 diff --git a/.github/workflows/startup-tests.yml b/.github/workflows/startup-tests.yml index 5320fbeb04..e603cfb0bc 100644 --- a/.github/workflows/startup-tests.yml +++ b/.github/workflows/startup-tests.yml @@ -81,7 +81,7 @@ jobs: working-directory: ${{ env.backend-directory }} run: poetry install - name: Install pnpm - uses: pnpm/action-setup@v4 + uses: pnpm/action-setup@v5 with: version: 10 - name: Install frontend dependencies @@ -134,7 +134,7 @@ jobs: with: node-version: lts/* - name: Install pnpm - uses: pnpm/action-setup@v4 + uses: pnpm/action-setup@v5 with: version: 10 - name: Install frontend dependencies