Skip to content

Commit 4765592

Browse files
author
HeroKwon
authored
test: Improve test coverage to 100% across all metrics (#90)
* chore(LinkButton): Add SSR guard comment * test(Checkbox): Add test cases for states * chore(Switch): Remove redundant `disabled` check in `handleClick` function * chore(Select): Remove redundant `disabled` check in `handleChange` function * chore(SelectItem): Add `onKeyDown` prop to `SelectItemProps` for better accessibility * test(Select): Add test cases for uncovered lines * test(Checkbox): Update expectation for minus path to be `falsy` * chore(SelectItem): Remove unused `onKeyDown` prop from `SelectItemProps` * test(Select): Refactor `SelectItem` mapping for improved readability
1 parent 83423d3 commit 4765592

5 files changed

Lines changed: 91 additions & 13 deletions

File tree

‎src/components/Button/LinkButton.tsx‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ export const LinkButton = ({
4949
testId={testId}
5050
label={label}
5151
onClick={e => {
52+
/* istanbul ignore next -- SSR/Node guard: not reachable in jsdom tests */
5253
if (typeof window === 'undefined') return;
5354

5455
props.onClick?.(e);

‎src/components/Checkbox/Checkbox.test.tsx‎

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,31 @@ describe('[Components] Checkbox', () => {
9191

9292
expect(minus).toHaveClass('opacity-0');
9393
});
94+
95+
it('checked + indeterminate: keeps minus visible and applies hiding class only to check mark', () => {
96+
const { rerender } = render(<Checkbox isChecked isIndeterminate />);
97+
const wrapper = screen.getByTestId('checkbox-wrapper');
98+
const svg = wrapper.querySelector('svg');
99+
const minus = svg?.querySelector('path:last-child');
100+
101+
expect(minus).not.toHaveClass('opacity-0');
102+
103+
expect(svg).toHaveClass('*:not-first:transition-opacity');
104+
expect(svg).toHaveClass('*:not-last:[path]:opacity-0');
105+
106+
rerender(<Checkbox isChecked isIndeterminate={false} />);
107+
108+
expect(minus).toHaveClass('opacity-0');
109+
});
110+
111+
it('unchecked without indeterminate: minus path is not rendered', () => {
112+
render(<Checkbox />);
113+
const wrapper = screen.getByTestId('checkbox-wrapper');
114+
const icon = wrapper.querySelector('svg');
115+
const minus = icon?.querySelector('path[d="M8 12h8"]:last-child');
116+
117+
expect(minus).toBeFalsy();
118+
});
94119
});
95120

96121
describe('interactions', () => {

‎src/components/Select/Select.test.tsx‎

Lines changed: 62 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,9 @@ const renderBase = (
2727
>
2828
<SelectTrigger placeholder="Fruits" />
2929
<SelectContent>
30-
{options.map(o => (
31-
<SelectItem key={o.value} value={o.value}>
32-
{o.content}
30+
{options.map(({ value, content }) => (
31+
<SelectItem key={value} value={value}>
32+
{content}
3333
</SelectItem>
3434
))}
3535
</SelectContent>
@@ -252,16 +252,41 @@ describe('[Components] Select (current implementation)', () => {
252252
expect(onChange).toHaveBeenCalledWith('peach');
253253
});
254254

255-
it('does not select a disabled option via keyboard', async () => {
255+
it('does not call onChange when other keys are pressed', async () => {
256+
const onChange = vi.fn();
257+
render(
258+
<Select getContent={getContent} onChange={onChange}>
259+
<SelectTrigger placeholder="Fruits" />
260+
<SelectContent>
261+
{options.map(({ value, content }) => (
262+
<SelectItem key={value} value={value}>
263+
{content}
264+
</SelectItem>
265+
))}
266+
</SelectContent>
267+
</Select>,
268+
);
269+
270+
const trigger = screen.getByTestId('select-trigger');
271+
await userEvent.click(trigger);
272+
273+
const banana = screen.getByRole('option', { name: 'Banana' });
274+
banana.focus();
275+
await userEvent.keyboard('A');
276+
277+
expect(onChange).not.toHaveBeenCalled();
278+
});
279+
280+
it('does not call onChange when clicking a disabled option', async () => {
256281
const onChange = vi.fn();
257282
render(
258283
<Select getContent={getContent} onChange={onChange}>
259284
<SelectTrigger placeholder="Fruits" />
260285
<SelectContent>
261286
{[
262-
...options.map(o => (
263-
<SelectItem key={o.value} value={o.value}>
264-
{o.content}
287+
...options.map(({ value, content }) => (
288+
<SelectItem key={value} value={value}>
289+
{content}
265290
</SelectItem>
266291
)),
267292
<SelectItem key="disabled-item" value="disabled-item" isDisabled>
@@ -271,12 +296,42 @@ describe('[Components] Select (current implementation)', () => {
271296
</SelectContent>
272297
</Select>,
273298
);
299+
274300
const trigger = screen.getByTestId('select-trigger');
301+
await userEvent.click(trigger);
302+
303+
const disabled = screen.getByRole('option', { name: 'Disabled Option' });
304+
await userEvent.click(disabled);
275305

306+
expect(onChange).not.toHaveBeenCalled();
307+
});
308+
309+
it('does not select a disabled option via keyboard', async () => {
310+
const onChange = vi.fn();
311+
render(
312+
<Select getContent={getContent} onChange={onChange}>
313+
<SelectTrigger placeholder="Fruits" />
314+
<SelectContent>
315+
{[
316+
...options.map(({ value, content }) => (
317+
<SelectItem key={value} value={value}>
318+
{content}
319+
</SelectItem>
320+
)),
321+
<SelectItem key="disabled-item" value="disabled-item" isDisabled>
322+
Disabled Option
323+
</SelectItem>,
324+
]}
325+
</SelectContent>
326+
</Select>,
327+
);
328+
329+
const trigger = screen.getByTestId('select-trigger');
276330
await userEvent.click(trigger);
277331

278332
const disabled = screen.getByRole('option', { name: 'Disabled Option' });
279333
disabled.focus();
334+
280335
await userEvent.keyboard('{Enter}');
281336
await userEvent.keyboard(' ');
282337

‎src/components/Select/Select.tsx‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,6 @@ export const Select = ({
7878
const selectedValue = isControlled ? value : internalValue;
7979

8080
const handleChange = (value: string) => {
81-
if (isDisabled) return;
82-
8381
if (!isControlled) {
8482
setInternalValue(value);
8583
}

‎src/components/Switch/Switch.tsx‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,14 +51,13 @@ export const Switch = ({
5151
const isControlled = typeof checked !== 'undefined';
5252
const isChecked: boolean = isControlled ? checked : internalChecked;
5353

54-
const handleClick = () => {
55-
if (isDisabled) return;
56-
54+
const handleClick = (e => {
5755
if (!isControlled) {
5856
setInternalChecked(!isChecked);
5957
}
6058
onChange?.(!isChecked);
61-
};
59+
props.onClick?.(e);
60+
}) satisfies React.MouseEventHandler<HTMLButtonElement>;
6261

6362
return (
6463
<Flex

0 commit comments

Comments
 (0)