diff --git a/cmp/internal/diff/diff_test.go b/cmp/internal/diff/diff_test.go index eacf072..f351c18 100644 --- a/cmp/internal/diff/diff_test.go +++ b/cmp/internal/diff/diff_test.go @@ -243,8 +243,8 @@ func TestDifference(t *testing.T) { for _, tt := range tests { t.Run("", func(t *testing.T) { - x := strings.Replace(tt.x, " ", "", -1) - y := strings.Replace(tt.y, " ", "", -1) + x := strings.ReplaceAll(tt.x, " ", "") + y := strings.ReplaceAll(tt.y, " ", "") es := testStrings(t, x, y) var want string got := es.String() diff --git a/cmp/internal/value/name_test.go b/cmp/internal/value/name_test.go index c93990a..1f20bc3 100644 --- a/cmp/internal/value/name_test.go +++ b/cmp/internal/value/name_test.go @@ -129,14 +129,14 @@ func TestTypeString(t *testing.T) { for _, tt := range tests { typ := reflect.TypeOf(tt.in) wantShort := tt.want - wantShort = strings.Replace(wantShort, "$PackagePath", "value", -1) - wantShort = strings.Replace(wantShort, "$FieldPrefix.", "", -1) + wantShort = strings.ReplaceAll(wantShort, "$PackagePath", "value") + wantShort = strings.ReplaceAll(wantShort, "$FieldPrefix.", "") if gotShort := TypeString(typ, false); gotShort != wantShort { t.Errorf("TypeString(%v, false) mismatch:\ngot: %v\nwant: %v", typ, gotShort, wantShort) } wantQualified := tt.want - wantQualified = strings.Replace(wantQualified, "$PackagePath", `"`+pkgPath+`"`, -1) - wantQualified = strings.Replace(wantQualified, "$FieldPrefix", `"`+pkgPath+`"`, -1) + wantQualified = strings.ReplaceAll(wantQualified, "$PackagePath", `"`+pkgPath+`"`) + wantQualified = strings.ReplaceAll(wantQualified, "$FieldPrefix", `"`+pkgPath+`"`) if gotQualified := TypeString(typ, true); gotQualified != wantQualified { t.Errorf("TypeString(%v, true) mismatch:\ngot: %v\nwant: %v", typ, gotQualified, wantQualified) }