From 5014bbb76cdd20e5f3a22a0378029940cbcc357d Mon Sep 17 00:00:00 2001 From: luo2430 Date: Thu, 2 Jul 2026 06:44:05 +0800 Subject: [PATCH 1/5] feat(galacean): add conditional exports with browser field support --- packages/galacean/package.json | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/packages/galacean/package.json b/packages/galacean/package.json index 95ae32ab5a..541afe0977 100644 --- a/packages/galacean/package.json +++ b/packages/galacean/package.json @@ -12,9 +12,16 @@ "types": "types/index.d.ts", "main": "dist/main.js", "module": "dist/module.js", - "browser": "dist/browser.js", "unpkg": "dist/bundled.module.min.js", "jsdelivr": "dist/bundled.module.min.js", + "exports": { + ".": { + "types": "./types/index.d.ts", + "import": "./dist/module.js", + "browser": "./dist/browser.js", + "default": "./dist/main.js" + } + }, "files": [ "dist/**/*", "types/**/*" From 48abd80c8eb24ad77d859050de53cd5802665c8e Mon Sep 17 00:00:00 2001 From: luo2430 Date: Thu, 2 Jul 2026 06:46:52 +0800 Subject: [PATCH 2/5] refactor(galacean): replace @ts-ignore with @ts-expect-error and modernize loop --- packages/galacean/src/ShaderPool.ts | 4 ++-- packages/galacean/src/index.ts | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/galacean/src/ShaderPool.ts b/packages/galacean/src/ShaderPool.ts index 52878d4d3f..430d9f335e 100644 --- a/packages/galacean/src/ShaderPool.ts +++ b/packages/galacean/src/ShaderPool.ts @@ -79,7 +79,7 @@ export class ShaderPool { ]; for (const source of sources) { - // @ts-ignore — `_createFromPrecompiled` is `Shader` @internal. + // @ts-expect-error — `_createFromPrecompiled` is `Shader` @internal. Shader._createFromPrecompiled(source); } @@ -87,7 +87,7 @@ export class ShaderPool { // The pass itself is later looked up via `Shader.find` inside // `ParticleTransformFeedbackSimulator`, so no caching needed here. const feedbackPass = Shader.find("Effect/ParticleFeedback").subShaders[0].passes[0]; - // @ts-ignore — `_feedbackVaryings` is `ShaderPass` @internal. + // @ts-expect-error — `_feedbackVaryings` is `ShaderPass` @internal. feedbackPass._feedbackVaryings = ["v_FeedbackPosition", "v_FeedbackVelocity"]; } } diff --git a/packages/galacean/src/index.ts b/packages/galacean/src/index.ts index de3768419f..0afb7953fa 100644 --- a/packages/galacean/src/index.ts +++ b/packages/galacean/src/index.ts @@ -1,7 +1,7 @@ import * as CoreObjects from "@galacean/engine-core"; import { Loader, Polyfill, SystemInfo } from "@galacean/engine-core"; import { ShaderPool } from "./ShaderPool"; -//@ts-ignore + export const version = `__buildVersion`; console.log(`Galacean Engine Version: ${version}`); @@ -11,8 +11,8 @@ export * from "@galacean/engine-loader"; export * from "@galacean/engine-math"; export * from "@galacean/engine-rhi-webgl"; -for (let key in CoreObjects) { - Loader.registerClass(key, CoreObjects[key]); +for (const [key, value] of Object.entries(CoreObjects)) { + Loader.registerClass(key, value); } // Bootstrap the Galacean engine flavor: browser polyfills first (must @@ -26,7 +26,7 @@ for (let key in CoreObjects) { // shader bundle dependency), which in turn lets the offline shader // compiler import core's enums without dragging the full runtime closure. Polyfill.registerPolyfill(); -// @ts-ignore — `_initialize` is `SystemInfo` @internal. +// @ts-expect-error — `_initialize` is `SystemInfo` @internal. SystemInfo._initialize(); ShaderPool.init(); ShaderPool.registerShaders(); From ffa133f02025f8ffa621194f87d0c909f62286b2 Mon Sep 17 00:00:00 2001 From: luo2430 Date: Thu, 2 Jul 2026 07:41:52 +0800 Subject: [PATCH 3/5] Revert "refactor(galacean): replace @ts-ignore with @ts-expect-error and modernize loop" This reverts commit 48abd80c8eb24ad77d859050de53cd5802665c8e. --- packages/galacean/src/ShaderPool.ts | 4 ++-- packages/galacean/src/index.ts | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/galacean/src/ShaderPool.ts b/packages/galacean/src/ShaderPool.ts index 430d9f335e..52878d4d3f 100644 --- a/packages/galacean/src/ShaderPool.ts +++ b/packages/galacean/src/ShaderPool.ts @@ -79,7 +79,7 @@ export class ShaderPool { ]; for (const source of sources) { - // @ts-expect-error — `_createFromPrecompiled` is `Shader` @internal. + // @ts-ignore — `_createFromPrecompiled` is `Shader` @internal. Shader._createFromPrecompiled(source); } @@ -87,7 +87,7 @@ export class ShaderPool { // The pass itself is later looked up via `Shader.find` inside // `ParticleTransformFeedbackSimulator`, so no caching needed here. const feedbackPass = Shader.find("Effect/ParticleFeedback").subShaders[0].passes[0]; - // @ts-expect-error — `_feedbackVaryings` is `ShaderPass` @internal. + // @ts-ignore — `_feedbackVaryings` is `ShaderPass` @internal. feedbackPass._feedbackVaryings = ["v_FeedbackPosition", "v_FeedbackVelocity"]; } } diff --git a/packages/galacean/src/index.ts b/packages/galacean/src/index.ts index 0afb7953fa..de3768419f 100644 --- a/packages/galacean/src/index.ts +++ b/packages/galacean/src/index.ts @@ -1,7 +1,7 @@ import * as CoreObjects from "@galacean/engine-core"; import { Loader, Polyfill, SystemInfo } from "@galacean/engine-core"; import { ShaderPool } from "./ShaderPool"; - +//@ts-ignore export const version = `__buildVersion`; console.log(`Galacean Engine Version: ${version}`); @@ -11,8 +11,8 @@ export * from "@galacean/engine-loader"; export * from "@galacean/engine-math"; export * from "@galacean/engine-rhi-webgl"; -for (const [key, value] of Object.entries(CoreObjects)) { - Loader.registerClass(key, value); +for (let key in CoreObjects) { + Loader.registerClass(key, CoreObjects[key]); } // Bootstrap the Galacean engine flavor: browser polyfills first (must @@ -26,7 +26,7 @@ for (const [key, value] of Object.entries(CoreObjects)) { // shader bundle dependency), which in turn lets the offline shader // compiler import core's enums without dragging the full runtime closure. Polyfill.registerPolyfill(); -// @ts-expect-error — `_initialize` is `SystemInfo` @internal. +// @ts-ignore — `_initialize` is `SystemInfo` @internal. SystemInfo._initialize(); ShaderPool.init(); ShaderPool.registerShaders(); From 7bae7d55f48e3d02d61c753c60435150cbec60fd Mon Sep 17 00:00:00 2001 From: luo2430 Date: Thu, 2 Jul 2026 07:42:02 +0800 Subject: [PATCH 4/5] Revert "feat(galacean): add conditional exports with browser field support" This reverts commit 5014bbb76cdd20e5f3a22a0378029940cbcc357d. --- packages/galacean/package.json | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/packages/galacean/package.json b/packages/galacean/package.json index 541afe0977..95ae32ab5a 100644 --- a/packages/galacean/package.json +++ b/packages/galacean/package.json @@ -12,16 +12,9 @@ "types": "types/index.d.ts", "main": "dist/main.js", "module": "dist/module.js", + "browser": "dist/browser.js", "unpkg": "dist/bundled.module.min.js", "jsdelivr": "dist/bundled.module.min.js", - "exports": { - ".": { - "types": "./types/index.d.ts", - "import": "./dist/module.js", - "browser": "./dist/browser.js", - "default": "./dist/main.js" - } - }, "files": [ "dist/**/*", "types/**/*" From e4cfc2d9e48c775cf860fd324e361320716f90c3 Mon Sep 17 00:00:00 2001 From: luo2430 Date: Thu, 2 Jul 2026 07:43:16 +0800 Subject: [PATCH 5/5] feat(galacean): add conditional exports - BREAKING/behavior-change --- packages/galacean/package.json | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/packages/galacean/package.json b/packages/galacean/package.json index 95ae32ab5a..de94d5f0d2 100644 --- a/packages/galacean/package.json +++ b/packages/galacean/package.json @@ -15,6 +15,13 @@ "browser": "dist/browser.js", "unpkg": "dist/bundled.module.min.js", "jsdelivr": "dist/bundled.module.min.js", + "exports": { + ".": { + "types": "./types/index.d.ts", + "import": "./dist/module.js", + "default": "./dist/main.js" + } + }, "files": [ "dist/**/*", "types/**/*"