From 3d72b44e72103c2bf0683eb3b2376c7372bc12b2 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed, 15 Jul 2026 16:44:56 +0000 Subject: [PATCH] dreaming: clarify RenderImmediateMessage usage in TerminalLogger Recurring reviewer feedback (PRs #14356, #14370, rainersigwald) flagged direct terminal writes for immediate messages instead of using the established RenderImmediateMessage path. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- .github/instructions/logging.instructions.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/instructions/logging.instructions.md b/.github/instructions/logging.instructions.md index 029b04087f7..57f5b4b09ba 100644 --- a/.github/instructions/logging.instructions.md +++ b/.github/instructions/logging.instructions.md @@ -18,6 +18,7 @@ Binary logger, console loggers, terminal logger, and event forwarding infrastruc * Must handle terminal width changes, very narrow terminals, and non-TTY output (piped to file). * Concurrent project builds must render without corruption. * ANSI escape sequences must be cross-platform compatible. +* Use `RenderImmediateMessage` (not direct terminal writes) for any message that must appear immediately outside the normal node-status rendering cycle — for example, messages with a null `BuildEventContext` or `IsAuthProviderMessage` events. Direct terminal writes bypass the node-display logic and corrupt the rendered output. ## Console Logger