|
| 1 | +package commands |
| 2 | + |
| 3 | +import ( |
| 4 | + "os" |
| 5 | + "sort" |
| 6 | + "testing" |
| 7 | + |
| 8 | + "github.com/devbytes-cloud/freight/internal/config" |
| 9 | + "github.com/stretchr/testify/assert" |
| 10 | + "github.com/stretchr/testify/require" |
| 11 | + "gopkg.in/yaml.v3" |
| 12 | +) |
| 13 | + |
| 14 | +func TestInitMergeAllow(t *testing.T) { |
| 15 | + _, cleanup := withTempGitDir(t) |
| 16 | + defer cleanup() |
| 17 | + |
| 18 | + fingerprintPath := ".git/hooks/.fingerprint.yaml" |
| 19 | + |
| 20 | + t.Run("Initial init with specific allow", func(t *testing.T) { |
| 21 | + cmd := NewRootCmd() |
| 22 | + cmd.SetArgs([]string{"init", "--allow", "pre-commit,commit-msg"}) |
| 23 | + err := cmd.Execute() |
| 24 | + require.NoError(t, err) |
| 25 | + |
| 26 | + // Check fingerprint |
| 27 | + data, err := os.ReadFile(fingerprintPath) |
| 28 | + require.NoError(t, err) |
| 29 | + |
| 30 | + var cfg config.FreightConfig |
| 31 | + err = yaml.Unmarshal(data, &cfg) |
| 32 | + require.NoError(t, err) |
| 33 | + |
| 34 | + sort.Strings(cfg.Allow) |
| 35 | + assert.Equal(t, []string{"commit-msg", "pre-commit"}, cfg.Allow) |
| 36 | + }) |
| 37 | + |
| 38 | + t.Run("Merge new allow with existing", func(t *testing.T) { |
| 39 | + cmd := NewRootCmd() |
| 40 | + cmd.SetArgs([]string{"init", "--allow", "post-commit"}) |
| 41 | + err := cmd.Execute() |
| 42 | + require.NoError(t, err) |
| 43 | + |
| 44 | + // Check fingerprint |
| 45 | + data, err := os.ReadFile(fingerprintPath) |
| 46 | + require.NoError(t, err) |
| 47 | + |
| 48 | + var cfg config.FreightConfig |
| 49 | + err = yaml.Unmarshal(data, &cfg) |
| 50 | + require.NoError(t, err) |
| 51 | + |
| 52 | + sort.Strings(cfg.Allow) |
| 53 | + assert.Equal(t, []string{"commit-msg", "post-commit", "pre-commit"}, cfg.Allow) |
| 54 | + }) |
| 55 | + |
| 56 | + t.Run("No duplicates when merging", func(t *testing.T) { |
| 57 | + cmd := NewRootCmd() |
| 58 | + cmd.SetArgs([]string{"init", "--allow", "pre-commit,post-checkout"}) |
| 59 | + err := cmd.Execute() |
| 60 | + require.NoError(t, err) |
| 61 | + |
| 62 | + // Check fingerprint |
| 63 | + data, err := os.ReadFile(fingerprintPath) |
| 64 | + require.NoError(t, err) |
| 65 | + |
| 66 | + var cfg config.FreightConfig |
| 67 | + err = yaml.Unmarshal(data, &cfg) |
| 68 | + require.NoError(t, err) |
| 69 | + |
| 70 | + sort.Strings(cfg.Allow) |
| 71 | + assert.Equal(t, []string{"commit-msg", "post-checkout", "post-commit", "pre-commit"}, cfg.Allow) |
| 72 | + }) |
| 73 | + |
| 74 | + t.Run("Only specified hooks are initialized with --allow", func(t *testing.T) { |
| 75 | + // Clean up and start fresh |
| 76 | + err := os.RemoveAll(".git/hooks") |
| 77 | + require.NoError(t, err) |
| 78 | + err = os.MkdirAll(".git/hooks", 0o755) |
| 79 | + require.NoError(t, err) |
| 80 | + |
| 81 | + // 1. Init with pre-commit |
| 82 | + cmd := NewRootCmd() |
| 83 | + cmd.SetArgs([]string{"init", "--allow", "pre-commit"}) |
| 84 | + err = cmd.Execute() |
| 85 | + require.NoError(t, err) |
| 86 | + |
| 87 | + require.FileExists(t, ".git/hooks/pre-commit") |
| 88 | + _, err = os.Stat(".git/hooks/post-commit") |
| 89 | + assert.True(t, os.IsNotExist(err)) |
| 90 | + |
| 91 | + // 2. Init with post-commit. It should NOT re-initialize pre-commit (though pre-commit should still exist if it was there) |
| 92 | + // To truly test it ONLY runs post-commit, we can delete pre-commit and see if it comes back. |
| 93 | + err = os.Remove(".git/hooks/pre-commit") |
| 94 | + require.NoError(t, err) |
| 95 | + |
| 96 | + cmd = NewRootCmd() |
| 97 | + cmd.SetArgs([]string{"init", "--allow", "post-commit"}) |
| 98 | + err = cmd.Execute() |
| 99 | + require.NoError(t, err) |
| 100 | + |
| 101 | + require.FileExists(t, ".git/hooks/post-commit") |
| 102 | + _, err = os.Stat(".git/hooks/pre-commit") |
| 103 | + assert.True(t, os.IsNotExist(err), "pre-commit should not have been re-initialized") |
| 104 | + |
| 105 | + // 3. Check fingerprint has BOTH |
| 106 | + data, err := os.ReadFile(fingerprintPath) |
| 107 | + require.NoError(t, err) |
| 108 | + var cfg config.FreightConfig |
| 109 | + err = yaml.Unmarshal(data, &cfg) |
| 110 | + require.NoError(t, err) |
| 111 | + sort.Strings(cfg.Allow) |
| 112 | + assert.Equal(t, []string{"post-commit", "pre-commit"}, cfg.Allow) |
| 113 | + }) |
| 114 | +} |
0 commit comments