Repository navigation
Commit 614fedd
authored
Wait for the sender before checking its status in NotificationServiceTest (#634)
Fixes #633.
Four tests in `NotificationServiceTest` (`basic_send_recv` and three
others with the same shape) wait only on the receiving workflow, then
assert that both workflows are SUCCESS. The receiver can finish as soon
as the sender's `send` step commits the message, which is before the
sender records SUCCESS. On a slow runner the sender was still PENDING,
as in the On Push run for #632, where the failure skipped that commit's
publish.
Each test now calls `handle2.getResult()` before the status asserts.
This is a test-only change. The other tests that assert a second handle
is SUCCESS (`DynamicQueuesTest`, `StaticQueuesTest`, `ForkTest`) already
wait on it first.
🤖 Generated with [Claude Code](https://claude.com/claude-code)1 parent fdedb3a commit 614fedd
1 file changed
Lines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
187 | 187 | | |
188 | 188 | | |
189 | 189 | | |
| 190 | + | |
| 191 | + | |
190 | 192 | | |
191 | 193 | | |
192 | 194 | | |
| |||
271 | 273 | | |
272 | 274 | | |
273 | 275 | | |
| 276 | + | |
| 277 | + | |
274 | 278 | | |
275 | 279 | | |
276 | 280 | | |
| |||
333 | 337 | | |
334 | 338 | | |
335 | 339 | | |
| 340 | + | |
| 341 | + | |
336 | 342 | | |
337 | 343 | | |
338 | 344 | | |
| |||
422 | 428 | | |
423 | 429 | | |
424 | 430 | | |
| 431 | + | |
| 432 | + | |
425 | 433 | | |
426 | 434 | | |
427 | 435 | | |
| |||
0 commit comments