From c1d5218f12c8c3caa512326c5ed5238667249b09 Mon Sep 17 00:00:00 2001 From: Roman <51091564+jeanpierreroma@users.noreply.github.com> Date: Tue, 8 Sep 2026 13:52:55 +0300 Subject: [PATCH] chore: bump rust-dashcore to dev head (#1000 merged: a known transaction is not announced new twice) Moves the pin from 93260bf3 (#998) to 7e315af5, one commit ahead and the current head of `dev`. The delta is dashpay/rust-dashcore#1000 alone, touching one file, `key-wallet/src/transaction_checking/wallet_checker.rs`. Upstream's `is_new` polled only `affected_accounts`, a set that is not stable across deliveries: an account that matched solely because the transaction spent its coin drops out on every later delivery, the coin having left `utxos` when the spend was recorded. Once the account holding the record stops matching, a transaction the wallet has held all along is announced as new a second time. It now asks every account, behind the existing relevance early-return. Upstream measured 13-14 double counts per full mainnet restore, a reported total of 6800 or 6801 over the same 6787 transactions; with the fix the total is 6787 on every run. Nothing in platform reads `is_new_transaction` outside two assertions in `test_support.rs`, so the surface here is the pin itself. --- Cargo.lock | 24 ++++++++++++------------ Cargo.toml | 16 ++++++++-------- 2 files changed, 20 insertions(+), 20 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index dfcf96c827e..7c46fd7bd7c 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1662,7 +1662,7 @@ dependencies = [ [[package]] name = "dash-network" version = "0.45.0" -source = "git+https://github.com/dashpay/rust-dashcore?rev=93260bf39bac5d9d09e89bfb45e9ea3ff7fdcbcd#93260bf39bac5d9d09e89bfb45e9ea3ff7fdcbcd" +source = "git+https://github.com/dashpay/rust-dashcore?rev=7e315af582bc6ec9c088447a7699099b5fbf0f96#7e315af582bc6ec9c088447a7699099b5fbf0f96" dependencies = [ "bincode", "bincode_derive", @@ -1673,7 +1673,7 @@ dependencies = [ [[package]] name = "dash-network-seeds" version = "0.45.0" -source = "git+https://github.com/dashpay/rust-dashcore?rev=93260bf39bac5d9d09e89bfb45e9ea3ff7fdcbcd#93260bf39bac5d9d09e89bfb45e9ea3ff7fdcbcd" +source = "git+https://github.com/dashpay/rust-dashcore?rev=7e315af582bc6ec9c088447a7699099b5fbf0f96#7e315af582bc6ec9c088447a7699099b5fbf0f96" dependencies = [ "dash-network", ] @@ -1768,7 +1768,7 @@ dependencies = [ [[package]] name = "dash-spv" version = "0.45.0" -source = "git+https://github.com/dashpay/rust-dashcore?rev=93260bf39bac5d9d09e89bfb45e9ea3ff7fdcbcd#93260bf39bac5d9d09e89bfb45e9ea3ff7fdcbcd" +source = "git+https://github.com/dashpay/rust-dashcore?rev=7e315af582bc6ec9c088447a7699099b5fbf0f96#7e315af582bc6ec9c088447a7699099b5fbf0f96" dependencies = [ "async-trait", "chrono", @@ -1797,7 +1797,7 @@ dependencies = [ [[package]] name = "dashcore" version = "0.45.0" -source = "git+https://github.com/dashpay/rust-dashcore?rev=93260bf39bac5d9d09e89bfb45e9ea3ff7fdcbcd#93260bf39bac5d9d09e89bfb45e9ea3ff7fdcbcd" +source = "git+https://github.com/dashpay/rust-dashcore?rev=7e315af582bc6ec9c088447a7699099b5fbf0f96#7e315af582bc6ec9c088447a7699099b5fbf0f96" dependencies = [ "anyhow", "base64-compat", @@ -1823,12 +1823,12 @@ dependencies = [ [[package]] name = "dashcore-private" version = "0.45.0" -source = "git+https://github.com/dashpay/rust-dashcore?rev=93260bf39bac5d9d09e89bfb45e9ea3ff7fdcbcd#93260bf39bac5d9d09e89bfb45e9ea3ff7fdcbcd" +source = "git+https://github.com/dashpay/rust-dashcore?rev=7e315af582bc6ec9c088447a7699099b5fbf0f96#7e315af582bc6ec9c088447a7699099b5fbf0f96" [[package]] name = "dashcore-rpc" version = "0.45.0" -source = "git+https://github.com/dashpay/rust-dashcore?rev=93260bf39bac5d9d09e89bfb45e9ea3ff7fdcbcd#93260bf39bac5d9d09e89bfb45e9ea3ff7fdcbcd" +source = "git+https://github.com/dashpay/rust-dashcore?rev=7e315af582bc6ec9c088447a7699099b5fbf0f96#7e315af582bc6ec9c088447a7699099b5fbf0f96" dependencies = [ "dashcore-rpc-json", "hex", @@ -1841,7 +1841,7 @@ dependencies = [ [[package]] name = "dashcore-rpc-json" version = "0.45.0" -source = "git+https://github.com/dashpay/rust-dashcore?rev=93260bf39bac5d9d09e89bfb45e9ea3ff7fdcbcd#93260bf39bac5d9d09e89bfb45e9ea3ff7fdcbcd" +source = "git+https://github.com/dashpay/rust-dashcore?rev=7e315af582bc6ec9c088447a7699099b5fbf0f96#7e315af582bc6ec9c088447a7699099b5fbf0f96" dependencies = [ "bincode", "dashcore", @@ -1856,7 +1856,7 @@ dependencies = [ [[package]] name = "dashcore_hashes" version = "0.45.0" -source = "git+https://github.com/dashpay/rust-dashcore?rev=93260bf39bac5d9d09e89bfb45e9ea3ff7fdcbcd#93260bf39bac5d9d09e89bfb45e9ea3ff7fdcbcd" +source = "git+https://github.com/dashpay/rust-dashcore?rev=7e315af582bc6ec9c088447a7699099b5fbf0f96#7e315af582bc6ec9c088447a7699099b5fbf0f96" dependencies = [ "bincode", "dashcore-private", @@ -2925,7 +2925,7 @@ dependencies = [ [[package]] name = "git-state" version = "0.45.0" -source = "git+https://github.com/dashpay/rust-dashcore?rev=93260bf39bac5d9d09e89bfb45e9ea3ff7fdcbcd#93260bf39bac5d9d09e89bfb45e9ea3ff7fdcbcd" +source = "git+https://github.com/dashpay/rust-dashcore?rev=7e315af582bc6ec9c088447a7699099b5fbf0f96#7e315af582bc6ec9c088447a7699099b5fbf0f96" [[package]] name = "glob" @@ -4137,7 +4137,7 @@ dependencies = [ [[package]] name = "key-wallet" version = "0.45.0" -source = "git+https://github.com/dashpay/rust-dashcore?rev=93260bf39bac5d9d09e89bfb45e9ea3ff7fdcbcd#93260bf39bac5d9d09e89bfb45e9ea3ff7fdcbcd" +source = "git+https://github.com/dashpay/rust-dashcore?rev=7e315af582bc6ec9c088447a7699099b5fbf0f96#7e315af582bc6ec9c088447a7699099b5fbf0f96" dependencies = [ "aes", "async-trait", @@ -4166,7 +4166,7 @@ dependencies = [ [[package]] name = "key-wallet-ffi" version = "0.45.0" -source = "git+https://github.com/dashpay/rust-dashcore?rev=93260bf39bac5d9d09e89bfb45e9ea3ff7fdcbcd#93260bf39bac5d9d09e89bfb45e9ea3ff7fdcbcd" +source = "git+https://github.com/dashpay/rust-dashcore?rev=7e315af582bc6ec9c088447a7699099b5fbf0f96#7e315af582bc6ec9c088447a7699099b5fbf0f96" dependencies = [ "cbindgen 0.29.4", "dash-network", @@ -4182,7 +4182,7 @@ dependencies = [ [[package]] name = "key-wallet-manager" version = "0.45.0" -source = "git+https://github.com/dashpay/rust-dashcore?rev=93260bf39bac5d9d09e89bfb45e9ea3ff7fdcbcd#93260bf39bac5d9d09e89bfb45e9ea3ff7fdcbcd" +source = "git+https://github.com/dashpay/rust-dashcore?rev=7e315af582bc6ec9c088447a7699099b5fbf0f96#7e315af582bc6ec9c088447a7699099b5fbf0f96" dependencies = [ "async-trait", "bincode", diff --git a/Cargo.toml b/Cargo.toml index 5fc7a2a957c..946ff7328a0 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -53,14 +53,14 @@ members = [ ] [workspace.dependencies] -dashcore = { git = "https://github.com/dashpay/rust-dashcore", rev = "93260bf39bac5d9d09e89bfb45e9ea3ff7fdcbcd" } -dash-network-seeds = { git = "https://github.com/dashpay/rust-dashcore", rev = "93260bf39bac5d9d09e89bfb45e9ea3ff7fdcbcd" } -dash-spv = { git = "https://github.com/dashpay/rust-dashcore", rev = "93260bf39bac5d9d09e89bfb45e9ea3ff7fdcbcd" } -key-wallet = { git = "https://github.com/dashpay/rust-dashcore", rev = "93260bf39bac5d9d09e89bfb45e9ea3ff7fdcbcd" } -key-wallet-ffi = { git = "https://github.com/dashpay/rust-dashcore", rev = "93260bf39bac5d9d09e89bfb45e9ea3ff7fdcbcd" } -key-wallet-manager = { git = "https://github.com/dashpay/rust-dashcore", rev = "93260bf39bac5d9d09e89bfb45e9ea3ff7fdcbcd" } -dash-network = { git = "https://github.com/dashpay/rust-dashcore", rev = "93260bf39bac5d9d09e89bfb45e9ea3ff7fdcbcd" } -dashcore-rpc = { git = "https://github.com/dashpay/rust-dashcore", rev = "93260bf39bac5d9d09e89bfb45e9ea3ff7fdcbcd" } +dashcore = { git = "https://github.com/dashpay/rust-dashcore", rev = "7e315af582bc6ec9c088447a7699099b5fbf0f96" } +dash-network-seeds = { git = "https://github.com/dashpay/rust-dashcore", rev = "7e315af582bc6ec9c088447a7699099b5fbf0f96" } +dash-spv = { git = "https://github.com/dashpay/rust-dashcore", rev = "7e315af582bc6ec9c088447a7699099b5fbf0f96" } +key-wallet = { git = "https://github.com/dashpay/rust-dashcore", rev = "7e315af582bc6ec9c088447a7699099b5fbf0f96" } +key-wallet-ffi = { git = "https://github.com/dashpay/rust-dashcore", rev = "7e315af582bc6ec9c088447a7699099b5fbf0f96" } +key-wallet-manager = { git = "https://github.com/dashpay/rust-dashcore", rev = "7e315af582bc6ec9c088447a7699099b5fbf0f96" } +dash-network = { git = "https://github.com/dashpay/rust-dashcore", rev = "7e315af582bc6ec9c088447a7699099b5fbf0f96" } +dashcore-rpc = { git = "https://github.com/dashpay/rust-dashcore", rev = "7e315af582bc6ec9c088447a7699099b5fbf0f96" } tokio-metrics = "0.5" # Size-tuned profile for the iOS `rs-unified-sdk-ffi` staticlib, which