cmdeploy run fails with "Invalid domain name" for domains containing hyphens (-)

[Tslmuun]

When running ./scripts/cmdeploy run to update my chatmail instance, the deployment script fails with a red error message: Invalid domain name: chat.m-i.im.

​Prior to this update, the deployment worked perfectly with the exact same configuration.

Environment:
​OS: Ubuntu 24.04
​Domain: chat.m-i.im (contains a hyphen -)
​chatmail.ini configuration: mail_domain = chat.m-i.im (verified no trailing dot or spaces)

Steps to Reproduce:
​1. Configure mail_domain = chat.m-i.im in chatmail.ini.
​2. Run ./scripts/cmdeploy run.

​Actual Behavior:
The script crashes/aborts with the following error:
Invalid domain name: chat.m-i.im.

Expected Behavior:
The deployment should succeed, as the domain name is valid and has been working previously.

[missytake]

I confirmed the behavior and opened an upstream bug. As a workaround, you can comment out this line: https://github.com/chatmail/relay/blob/main/chatmaild/src/chatmaild/config.py#L28
and run cmdeploy run again. Let's keep this issue open until the upstream bug is fixed.

[feld]

The domain-validator library is broken in several ways and should not be used. Their regex is just plain wrong. One obvious example is that they are using \w which allows underscores but underscores aren't valid in domain names.

>>> validator.validate_domain_re("foo_bar.com")
>>> 

I would advise against using this library.

[link2xt]

Looks like dependency was introduced in 4ebde28 (originally #919, then #963)

Before squashing dependency was introduced in commit 27df0a4