fix(runtime-host): align artifact preview review fixes

Author: SummerC0zyR0ck

apps/desktop/src/main/__tests__/main-startup-lifetime.test.ts

@@ -133,6 +133,10 @@ test('wires Artifact deletion and purge events to preview invalidation for the a
   assert.match(handler, /managedArtifactPreview\.releaseSession\(scope\.targetEpoch,\s*frame\.sessionId\)/u);
   assert.match(bootSource, /managedArtifactPreview\.openScope\(scope\.targetEpoch\)/u);
   assert.match(bootSource, /await managedArtifactPreview\.closeScope\(scope\.targetEpoch\)/u);
+  assert.ok(
+    bootSource.indexOf('await managedArtifactPreview.closeScope(scope.targetEpoch)') <
+      bootSource.indexOf('unsubscribeArtifactChanges();'),
+  );
 });
 
 test('resolves persisted locale before first post-settings recovery prompt', () => {

apps/desktop/src/main/__tests__/managed-artifact-preview.test.ts

@@ -168,6 +168,9 @@ test('rejects previews above the global limit without invalidating existing sess
     await assert.rejects(service.prepare('h', client('replacement'), 's64', 'a1'), /across the Desktop/);
     assert.equal(await (await fetch(endpoints[0]!.url)).text(), 'preview-0');
     assert.equal(await (await fetch(endpoints[63]!.url)).text(), 'preview-63');
+    await service.releaseUrl(endpoints[0]!.url);
+    const replacement = await service.prepare('h', client('replacement'), 's64', 'a1');
+    assert.equal(await (await fetch(replacement.url)).text(), 'replacement');
   } finally {
     await service.close();
   }
@@ -181,14 +184,24 @@ test('reserves aggregate preview bytes before streaming and releases reservation
     getArtifact: async () => ({ id: 'a1', sessionId: 's1', turnId: 't1', createdAt: 0, name: 'large.html', kind: 'html' as const, sizeBytes: PREVIEW_MAX_BYTES, source: 'tool_result' as const }),
     streamArtifact: async () => { await gate; throw new Error('test stream failure'); },
   };
+  const successfulLarge = {
+    getArtifact: large.getArtifact,
+    streamArtifact: async (_sessionId: string, _artifactId: string, write: (chunk: Uint8Array) => Promise<void>) => {
+      const bytes = Buffer.alloc(PREVIEW_MAX_BYTES);
+      await write(bytes);
+      return bytes.length;
+    },
+  };
   const pending = Array.from({ length: 16 }, (_, index) => service.prepare('h', large, `s${index + 1}`, 'a1'));
   try {
     // Each in-flight Artifact reserves 8 MiB, reaching the 128 MiB aggregate budget.
     await new Promise((resolve) => setImmediate(resolve));
     await assert.rejects(service.prepare('h', large, 's17', 'a1'), /memory limit/);
     resume();
     await Promise.all(pending.map((preparation) => assert.rejects(preparation, /test stream failure/)));
-    assert.equal((await service.prepare('h', client(), 's1', 'a1')).reachable, true);
+    const recovered = await service.prepare('h', successfulLarge, 's1', 'a1');
+    assert.equal(recovered.reachable, true);
+    await service.releaseUrl(recovered.url);
   } finally {
     resume();
     await Promise.allSettled(pending);

packages/runtime-host/src/__tests__/host-change-feed.test.ts

@@ -57,7 +57,6 @@ test('routes each change kind only to subscribed connections', () => {
   feed.attachConnection(
     'other-guest',
     {
-      artifact: { sessionId: 'session-1' },
       sessionCatalog: { sessionId: 'session-1', principalId: 'guest-2' },
     },
     { send: async (frame) => void otherGuest.push(frame) },
@@ -99,37 +98,24 @@ test('routes each change kind only to subscribed connections', () => {
   assert.equal(otherGuest.length, 3);
 });
 
-test('routes Artifact invalidations by Session scope', () => {
+test('routes Artifact invalidations only to owner subscriptions', () => {
   const feed = new HostChangeFeed();
   const all: unknown[] = [];
-  const scoped: unknown[] = [];
+  const guest: unknown[] = [];
   feed.attachConnection(
     'all-artifacts',
     { artifact: true },
     {
       send: async (frame) => void all.push(frame),
     },
   );
-  feed.attachConnection(
-    'session-artifacts',
-    { artifact: { sessionId: 'session-1' } },
-    {
-      send: async (frame) => void scoped.push(frame),
-    },
-  );
+  feed.attachConnection('guest', {}, { send: async (frame) => void guest.push(frame) });
 
   feed.publishArtifactDeleted('session-1', 'artifact-1');
   feed.publishArtifactSessionPurged('session-2');
 
   assert.equal(all.length, 2);
-  assert.deepEqual(scoped, [
-    {
-      kind: 'artifact.changed',
-      reason: 'deleted',
-      sessionId: 'session-1',
-      artifactId: 'artifact-1',
-    },
-  ]);
+  assert.deepEqual(guest, []);
 });
 
 test('keeps catalog revisions independent and removes failed subscriptions', async () => {

packages/runtime-host/src/server/host-change-feed.ts

@@ -41,7 +41,7 @@ export interface HostChangeSubscription {
 }
 
 export interface HostChangeSubscriptionMask {
-  readonly artifact?: true | { readonly sessionId: string };
+  readonly artifact?: true;
   readonly configuration?: boolean;
   readonly connectionCatalog?: boolean;
   readonly projectCatalog?: boolean;
@@ -166,7 +166,6 @@ export class HostChangeFeed {
         this.#subscriptions.get(connectionId) === subscription
       ) {
         this.#subscriptions.delete(connectionId);
-        continue;
       }
     }
   }
@@ -175,10 +174,7 @@ export class HostChangeFeed {
 function isSubscribed(mask: HostChangeSubscriptionMask, frame: HostChangeFrame): boolean {
   switch (frame.kind) {
     case 'artifact.changed':
-      return (
-        mask.artifact === true ||
-        (mask.artifact !== undefined && frame.sessionId === mask.artifact.sessionId)
-      );
+      return mask.artifact === true;
     case 'configuration.changed':
       return mask.configuration === true;
     case 'connection.catalog.changed':