From 6c3a887fbdbb0eacb994e26070bae6c7591eb6e9 Mon Sep 17 00:00:00 2001 From: Akari Tsuyukusa Date: Fri, 22 May 2026 22:39:35 +0900 Subject: [PATCH 1/3] soc: mediatek: pwrap: Remove obsolete NEED CONFIRM comments Remove the obsolete "/* NEED CONFIRM */" comments from the MT8196 configuration. These values were previously confirmed during review, but the placeholder comments were accidentally left behind. Link: https://lore.kernel.org/all/2a117e5fe9fe0ece39e9165a463082ef42be973f.camel@mediatek.com/ Signed-off-by: Akari Tsuyukusa --- drivers/soc/mediatek/mtk-pmic-wrap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c index 0bcd8582637550..87bcbfa2d5f122 100644 --- a/drivers/soc/mediatek/mtk-pmic-wrap.c +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c @@ -2396,8 +2396,8 @@ static const struct pmic_wrapper_type pwrap_mt8183 = { static const struct pmic_wrapper_type pwrap_mt8195 = { .regs = mt8195_regs, .type = PWRAP_MT8195, - .arb_en_all = 0x777f, /* NEED CONFIRM */ - .int_en_all = 0x180000, /* NEED CONFIRM */ + .arb_en_all = 0x777f, + .int_en_all = 0x180000, .int1_en_all = 0, .spi_w = PWRAP_MAN_CMD_SPI_WRITE, .wdt_src = PWRAP_WDT_SRC_MASK_ALL, From 53470b7ebff648d1c8586f50069957347cbf6f2e Mon Sep 17 00:00:00 2001 From: Akari Tsuyukusa Date: Mon, 25 May 2026 18:00:51 +0900 Subject: [PATCH 2/3] Revert for PATCH v2 Revert "soc: mediatek: pwrap: Remove obsolete NEED CONFIRM comments" This reverts commit 6c3a887fbdbb0eacb994e26070bae6c7591eb6e9. --- drivers/soc/mediatek/mtk-pmic-wrap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c index 87bcbfa2d5f122..0bcd8582637550 100644 --- a/drivers/soc/mediatek/mtk-pmic-wrap.c +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c @@ -2396,8 +2396,8 @@ static const struct pmic_wrapper_type pwrap_mt8183 = { static const struct pmic_wrapper_type pwrap_mt8195 = { .regs = mt8195_regs, .type = PWRAP_MT8195, - .arb_en_all = 0x777f, - .int_en_all = 0x180000, + .arb_en_all = 0x777f, /* NEED CONFIRM */ + .int_en_all = 0x180000, /* NEED CONFIRM */ .int1_en_all = 0, .spi_w = PWRAP_MAN_CMD_SPI_WRITE, .wdt_src = PWRAP_WDT_SRC_MASK_ALL, From 9b58e7f289862b7081e96a7d49bd21bc57828ce0 Mon Sep 17 00:00:00 2001 From: Akari Tsuyukusa Date: Fri, 22 May 2026 22:39:35 +0900 Subject: [PATCH 3/3] soc: mediatek: pwrap: Remove obsolete NEED CONFIRM comments Remove the obsolete "/* NEED CONFIRM */" comments from the MT8195 configuration. These values were previously confirmed during review, but the placeholder comments were accidentally left behind. Link: https://lore.kernel.org/all/2a117e5fe9fe0ece39e9165a463082ef42be973f.camel@mediatek.com/ Signed-off-by: Akari Tsuyukusa Reviewed-by: AngeloGioacchino Del Regno --- drivers/soc/mediatek/mtk-pmic-wrap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c index 0bcd8582637550..87bcbfa2d5f122 100644 --- a/drivers/soc/mediatek/mtk-pmic-wrap.c +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c @@ -2396,8 +2396,8 @@ static const struct pmic_wrapper_type pwrap_mt8183 = { static const struct pmic_wrapper_type pwrap_mt8195 = { .regs = mt8195_regs, .type = PWRAP_MT8195, - .arb_en_all = 0x777f, /* NEED CONFIRM */ - .int_en_all = 0x180000, /* NEED CONFIRM */ + .arb_en_all = 0x777f, + .int_en_all = 0x180000, .int1_en_all = 0, .spi_w = PWRAP_MAN_CMD_SPI_WRITE, .wdt_src = PWRAP_WDT_SRC_MASK_ALL,