From a4453236d682edf7f73ad77f84ff972af2fdb7d9 Mon Sep 17 00:00:00 2001 From: Mengsu Ding Date: Sun, 5 Jul 2026 10:11:29 +0800 Subject: [PATCH] fix(tests): pass required --update-weight-local-checkpoint-dir in external_pd delta test --- tests/test_qwen3_4B_external_pd.py | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/tests/test_qwen3_4B_external_pd.py b/tests/test_qwen3_4B_external_pd.py index 4b5b87ce82..b6ded31659 100644 --- a/tests/test_qwen3_4B_external_pd.py +++ b/tests/test_qwen3_4B_external_pd.py @@ -255,6 +255,13 @@ def launch_external_engines(): delta_dir_cm = tempfile.TemporaryDirectory(prefix="slime_external_pd_delta_") delta_dir = delta_dir_cm.name + # delta + disk sync also needs a rollout-host-local dir where each host + # materializes the full HF checkpoint and patches it in place. af3d7fff + # ("Disk-level delta weight sync", #2089) made --update-weight-local-checkpoint-dir + # "Required for delta + disk" in arguments.py but did not update this test, + # so it aborted at arg validation until this dir is passed. + local_ckpt_cm = tempfile.TemporaryDirectory(prefix="slime_external_pd_localckpt_") + local_ckpt_dir = local_ckpt_cm.name try: ckpt_args = f"--hf-checkpoint /root/models/{MODEL_NAME}/ " f"--ref-load {TORCH_DIST_CKPT} " @@ -324,6 +331,7 @@ def launch_external_engines(): "--update-weight-transport disk " "--update-weight-encoding deltas " f"--update-weight-disk-dir {delta_dir} " + f"--update-weight-local-checkpoint-dir {local_ckpt_dir} " "--update-weight-delta-keep-files " ) @@ -372,6 +380,7 @@ def launch_external_engines(): p.wait() U.exec_command("pkill -9 sglang; true") delta_dir_cm.cleanup() + local_ckpt_cm.cleanup() if __name__ == "__main__":