From ecb15b82dddc2ec5640e3ffaabe29bc222d4acf9 Mon Sep 17 00:00:00 2001 From: jakemismas Date: Wed, 11 Mar 2026 00:38:36 -0700 Subject: [PATCH] Fix splitArgs silently dropping quoted arguments The argsPattern regex has two capture groups: group(1) for unquoted args and group(2) for quoted args. Only group(1) was being read, so any quoted argument like "-Dfoo=bar baz" was added as null to the argument list, corrupting the JVM command line. --- .../java/com/skcraft/launcher/launch/JavaProcessBuilder.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/launcher/src/main/java/com/skcraft/launcher/launch/JavaProcessBuilder.java b/launcher/src/main/java/com/skcraft/launcher/launch/JavaProcessBuilder.java index 7b7e40e1e..a9a5dbb36 100644 --- a/launcher/src/main/java/com/skcraft/launcher/launch/JavaProcessBuilder.java +++ b/launcher/src/main/java/com/skcraft/launcher/launch/JavaProcessBuilder.java @@ -129,7 +129,7 @@ public static List splitArgs(String str) { Matcher matcher = argsPattern.matcher(str); List parts = new ArrayList(); while (matcher.find()) { - parts.add(matcher.group(1)); + parts.add(matcher.group(1) != null ? matcher.group(1) : matcher.group(2)); } return parts; }