From 01d0b2441f343f302f24ac465dd8e1e2a5989a15 Mon Sep 17 00:00:00 2001 From: Erwan Legrand Date: Sat, 22 Aug 2026 12:34:55 +0000 Subject: [PATCH 1/2] fix(ci): build the Windows matrix for its target triple The windows job takes a target per matrix arm, exports it as TARGET and installs it for both toolchains, but no cargo invocation passed --target. Every step therefore built and tested the host triple, so the i686 arm silently duplicated the x64 one and 32-bit Windows was never covered. --- .github/workflows/platforms.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/platforms.yml b/.github/workflows/platforms.yml index 1c8317ab0..23728974e 100644 --- a/.github/workflows/platforms.yml +++ b/.github/workflows/platforms.yml @@ -265,20 +265,20 @@ jobs: key: windows-${{ matrix.arch }} - name: Run tests (default features) - run: cargo +${{ env.MSRV_WINDOWS }} test --workspace --verbose + run: cargo +${{ env.MSRV_WINDOWS }} test --workspace --verbose --target ${{ env.TARGET }} - name: Check examples (default features) - run: cargo +${{ env.MSRV_WINDOWS }} check --examples --workspace --verbose + run: cargo +${{ env.MSRV_WINDOWS }} check --examples --workspace --verbose --target ${{ env.TARGET }} - name: Run tests (all features) - run: cargo +${{ steps.msrv.outputs.all-features }} test --workspace --all-features --verbose + run: cargo +${{ steps.msrv.outputs.all-features }} test --workspace --all-features --verbose --target ${{ env.TARGET }} - name: Check examples (all features) - run: cargo +${{ steps.msrv.outputs.all-features }} check --examples --all-features --workspace --verbose + run: cargo +${{ steps.msrv.outputs.all-features }} check --examples --all-features --workspace --verbose --target ${{ env.TARGET }} - name: Build ASIO examples working-directory: asio-sys - run: cargo +${{ env.MSRV_WINDOWS }} build --examples --verbose --workspace + run: cargo +${{ env.MSRV_WINDOWS }} build --examples --verbose --workspace --target ${{ env.TARGET }} # macOS ARM64 macos: From 62c61dfdead3e444e2549445e35ec21dc87664e6 Mon Sep 17 00:00:00 2001 From: Erwan Legrand Date: Sat, 22 Aug 2026 12:51:48 +0000 Subject: [PATCH 2/2] fix(ci): lint the 32-bit Windows target The clippy matrix only covered x86_64-pc-windows-msvc, so i686 built in the platform workflow without ever being linted under -D warnings. Name the two arms Windows-x64 and Windows-x86, matching the x64/x86 vocabulary platforms.yml already uses for the same two targets. This renames the existing clippy-Windows check. --- .github/workflows/quality.yml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/quality.yml b/.github/workflows/quality.yml index e5e17c37e..bcf359374 100644 --- a/.github/workflows/quality.yml +++ b/.github/workflows/quality.yml @@ -43,7 +43,13 @@ jobs: # Windows - WASAPI backend - target: x86_64-pc-windows-msvc - name: Windows + name: Windows-x64 + features: --all-features + os: windows-latest + + # Windows 32-bit - WASAPI backend + - target: i686-pc-windows-msvc + name: Windows-x86 features: --all-features os: windows-latest