Fix saved rolls shifting when old mod lines are now item properties

PoB 2.66 and older saved in-game property lines such as "Intangibility: 5%"
and "Memory Strands: 58", and flask lines such as "Lasts 4.00 Seconds", as
mod lines with a ModRange entry each. 2.67 reads them as item properties or
skips them, so ItemsTab:Load applied every later ModRange one line too early:
an Entropy Grip saved in 2.66 loaded its "+(10-13) to all Attributes" roll at
0.5 instead of 1.

Save writes at most one ModRange per mod line, so more entries than lines
means the saved positions no longer match. The entries are then ignored and
the {range:} tags of the item text are kept.

The line count leaves out talisman enchants added from the base data, as the
ModRange id loop already does; both now use countSavedModLines.

Author: mcagnion

spec/System/TestItemParse_spec.lua

@@ -1053,6 +1053,28 @@ Implicits: 0
 		assert.are.equals(1, #item.explicitModLines)
 	end)
 
+	it("keeps saved rolls when a property was saved among the modifier lines", function()
+		loadBuildFromXML([[
+<PathOfBuilding>
+	<Build level="1" targetVersion="3_0" className="Scion" ascendClassName="None" mainSocketGroup="1"/>
+	<Items activeItemSet="1">
+		<Item id="1">
+Rarity: RARE
+Pain Shell
+Vaal Regalia
+Implicits: 0
+Intangibility: 7%
+{range:0}+(10-13) to all Attributes
+			<ModRange id="1" range="0.5"/>
+			<ModRange id="2" range="0"/>
+		</Item>
+		<ItemSet id="1"/>
+	</Items>
+</PathOfBuilding>]])
+
+		assert.are.equals(0, build.itemsTab.items[1].explicitModLines[1].range)
+	end)
+
 	it("preserves cluster jewel enchants from advanced copy", function()
 		newBuild()
 		runCallback("onFrame")

src/Classes/ItemsTab.lua

@@ -1218,6 +1218,11 @@ function ItemsTabClass:Load(xml, dbFileName)
 	self.itemSets = { }
 	self.itemSetOrderList = { }
 	self.tradeQuery.statSortSelectionList = { }
+	-- Enchants from the base data are only added to an item text without enchants and were not in the saved text,
+	-- so saved ModRange ids skip the whole list
+	local function countSavedModLines(modLines)
+		return modLines[1] and modLines[1].addedFromBase and 0 or #modLines
+	end
 	for _, node in ipairs(xml) do
 		if node.elem == "Item" then
 			local item = new("Item"):Item("")
@@ -1243,19 +1248,29 @@ function ItemsTabClass:Load(xml, dbFileName)
 				item.hasAltVariant5 = true
 				item.variantAlt5 = tonumber(node.attrib.variantAlt5)
 			end
+			local modRangeCount = 0
+			for _, child in ipairs(node) do
+				if type(child) == "table" and child.elem == "ModRange" then
+					modRangeCount = modRangeCount + 1
+				end
+			end
+			local ignoreModRanges
 			for _, child in ipairs(node) do
 				if type(child) == "string" then
 					item:ParseRaw(child)
-				elseif child.elem == "ModRange" then
+					-- Save writes at most one ModRange per mod line. More entries than lines means some saved lines are
+					-- no longer mod lines (e.g. Intangibility before 2.67), so the ids no longer match their lines and the
+					-- {range:} tags of the item text are kept instead
+					ignoreModRanges = modRangeCount > countSavedModLines(item.enchantModLines) + #item.scourgeModLines + #item.implicitModLines + #item.explicitModLines + #item.crucibleModLines
+				elseif child.elem == "ModRange" and not ignoreModRanges then
 					local id = tonumber(child.attrib.id) or 0
 					local range = tonumber(child.attrib.range) or 1
 					-- This is garbage, but needed due to change to separate mod line lists
 					-- 'ModRange' elements are legacy though, so is this actually needed? :<
 					-- Maybe it is? Maybe it isn't? Maybe up is down? Maybe good is bad? AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
 					-- Sorry, cluster jewels are making me crazy(-ier)
 					for _, list in ipairs{item.buffModLines, item.enchantModLines, item.scourgeModLines, item.implicitModLines, item.explicitModLines, item.crucibleModLines} do
-						-- Enchants added from the base data were not in the saved item text, so saved ids skip them
-						local savedLineCount = list[1] and list[1].addedFromBase and 0 or #list
+						local savedLineCount = countSavedModLines(list)
 						if id <= savedLineCount then
 							-- Versions that could not parse "value(min-max)" lines saved them as is with a default ModRange
 							if not list[id].rangeFromValue then