Skip to content

Taker reputation is received but never shown #305

Description

@Catrya

The daemon sends the maker an extra DM with the taker's
reputation: a Peer payload with an empty pubkey and
reputation: Some(UserInfo { rating, reviews, operating_days }), riding the
same PayInvoice / AddInvoice action as the flow message
(notify_taker_reputation() in mostrod's src/util.rs).

The app parses it — it shows up in the logs — but nothing surfaces it in the
UI, so the maker never sees who took their order:

gift-wrap: action=PayInvoice order_id=Some(9e60e970-…) trade_pubkey=bfff4ce5
payload=Peer(Peer { pubkey: "", reputation: Some(UserInfo { rating: 4.375, reviews: 4, operating_days: 64 }) })

The order book already renders the maker's reputation from the kind 38383
rating tag, so this is the missing counterpart side.

Expected: show it where the maker decides whether to continue — the
pay/add invoice screen and the trade detail — deriving the counterpart's role
from the user's own (paying the hold invoice ⇒ the taker is the buyer; adding
an invoice ⇒ the taker is the seller).

Note: a brand-new user and a full-privacy taker both arrive as zeros, so
they are indistinguishable on the wire.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions