From 5c477878b2662d59ad487bc3cad09fddc9ea207e Mon Sep 17 00:00:00 2001 From: Eric Stern Date: Tue, 11 Aug 2026 12:44:55 -0700 Subject: [PATCH 1/2] All GMP ignores are fixed upstream --- src/PublicKey/EllipticCurve.php | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/PublicKey/EllipticCurve.php b/src/PublicKey/EllipticCurve.php index d866442..4136980 100644 --- a/src/PublicKey/EllipticCurve.php +++ b/src/PublicKey/EllipticCurve.php @@ -152,16 +152,13 @@ private function isOnCurve(): bool // This is only tested with P256 (secp256r1) but SHOULD be the same for // the other curves (none of which are supported yet)/ - $x3 = $x ** 3; // @phpstan-ignore pow.leftNonNumeric (phpstan/phpstan#14288) - $ax = $a * $x; // @phpstan-ignore mul.leftNonNumeric, mul.rightNonNumeric (phpstan/phpstan#14288) - // phpcs:disable + $x3 = $x ** 3; + $ax = $a * $x; // (need the long line for PHPStan to parse) - // @phpstan-ignore plus.leftNonNumeric, plus.leftNonNumeric, plus.rightNonNumeric, plus.rightNonNumeric, mod.leftNonNumeric, mod.rightNonNumeric (phpstan/phpstan#14288) $rhs = ($x3 + $ax + $b) % $p; - // phpcs:enable - $y2 = $y ** 2; // @phpstan-ignore pow.leftNonNumeric (phpstan/phpstan#14288) - $lhs = $y2 % $p; // @phpstan-ignore mod.leftNonNumeric, mod.rightNonNumeric (phpstan/phpstan#14288) + $y2 = $y ** 2; + $lhs = $y2 % $p; // Functionaly, `$lhs === $rhs` but avoids reference equality issues // w/out having to introduce loose comparision ($lhs == $rhs works) From b43e6d47cd83b0db7490a61ce557da7010e96bbb Mon Sep 17 00:00:00 2001 From: Eric Stern Date: Tue, 11 Aug 2026 12:47:55 -0700 Subject: [PATCH 2/2] PHP Matrix too --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 18ab7d7..312efe3 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -24,7 +24,7 @@ jobs: - '8.3' - '8.4' - '8.5' - - '8.6-dev' + - '8.6' steps: - name: Check out code