From 1cc01c429fb51e072a3e3b33ee58b24bbf046d65 Mon Sep 17 00:00:00 2001 From: Tijmen Baarda Date: Thu, 26 Mar 2026 15:58:58 +0100 Subject: [PATCH 01/23] Add venv to gitignore --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 922c12c4..254e939d 100644 --- a/.gitignore +++ b/.gitignore @@ -4,6 +4,7 @@ # Virtual environment ENV/ .env/ +venv/ # node node_modules From af7c6f72d2e36a0c7af496fdda49baf513ebe9fb Mon Sep 17 00:00:00 2001 From: Tijmen Baarda Date: Thu, 26 Mar 2026 15:59:52 +0100 Subject: [PATCH 02/23] Change icon of annotation button to pen --- frontend/vre/field/field.view.mustache | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frontend/vre/field/field.view.mustache b/frontend/vre/field/field.view.mustache index 8c973dde..aa5be9f8 100644 --- a/frontend/vre/field/field.view.mustache +++ b/frontend/vre/field/field.view.mustache @@ -3,4 +3,4 @@ {{#linkedRecordUri}}{{displayText}}{{/linkedRecordUri}} {{^linkedRecordUri}}{{displayText}}{{/linkedRecordUri}}
- + From 37a762c653362c96f22264e0b39443d768371192 Mon Sep 17 00:00:00 2001 From: Tijmen Baarda Date: Thu, 26 Mar 2026 16:42:06 +0100 Subject: [PATCH 03/23] Prefill original text for new correcting annotations --- frontend/vre/annotation/annotation.edit.view.js | 5 +++-- frontend/vre/field/annotatable.view.js | 7 +++++-- frontend/vre/field/field.view.js | 7 +++++-- 3 files changed, 13 insertions(+), 6 deletions(-) diff --git a/frontend/vre/annotation/annotation.edit.view.js b/frontend/vre/annotation/annotation.edit.view.js index eba595b7..fcf50eb9 100644 --- a/frontend/vre/annotation/annotation.edit.view.js +++ b/frontend/vre/annotation/annotation.edit.view.js @@ -14,7 +14,7 @@ export var AnnotationEditView = View.extend({ 'reset': 'reset', }, initialize: function(options) { - _.assign(this, _.pick(options, ['existing'])); + _.assign(this, _.pick(options, ['existing', 'defaultText'])); this.render().$el.popover({ container: 'body', content: confirmDeletionTemplate(this), @@ -53,8 +53,9 @@ export var AnnotationEditView = View.extend({ if (tag) this.$('select').val(tag); this.$('select').trigger('change'); } else { + var text = this.model.get('oa:hasBody') || this.defaultText; this.$el.html(this.template({ - currentText: this.model.get('oa:hasBody'), + currentText: text, cid: this.cid, })); } diff --git a/frontend/vre/field/annotatable.view.js b/frontend/vre/field/annotatable.view.js index cf943b03..4b4dfb7f 100644 --- a/frontend/vre/field/annotatable.view.js +++ b/frontend/vre/field/annotatable.view.js @@ -17,7 +17,7 @@ export var AnnotatableView = AggregateView.extend({ this.listenTo(this.collection, 'edit', this.edit); }, - edit: function(model) { + edit: function(model, defaultText) { var project = vreChannel.request('projects:current').id, editTarget = model.clone().set('context', project), preExisting = this.collection.get(editTarget), @@ -32,7 +32,10 @@ export var AnnotatableView = AggregateView.extend({ this.items.splice(index, 1, newRow); oldRow.remove(); } else { - newRow = new AnnotationEditView({model: editTarget}); + newRow = new AnnotationEditView({ + model: editTarget, + defaultText: defaultText, + }); this.items.push(newRow); } this.placeItems(); diff --git a/frontend/vre/field/field.view.js b/frontend/vre/field/field.view.js index 014beb9e..cf671c82 100644 --- a/frontend/vre/field/field.view.js +++ b/frontend/vre/field/field.view.js @@ -54,11 +54,14 @@ export var FieldView = AnnotatableView.extend({ var attributes = { "oa:hasSource": this.collection.underlying.target, "edpopcol:field": fieldId, - "motivation": "oa:commenting", + "motivation": "oa:editing", }; if (fieldContents) { attributes['edpopcol:originalText'] = fieldContents['edpoprec:originalText']; } - this.edit(new Annotation(attributes)); + this.edit( + new Annotation(attributes), + fieldContents['edpoprec:originalText'], + ); }, }); From 63057a06266be1c683dacd15e767ffebd10b10ce Mon Sep 17 00:00:00 2001 From: Tijmen Baarda Date: Thu, 26 Mar 2026 16:42:17 +0100 Subject: [PATCH 04/23] Do not use nested table --- frontend/vre/annotation/annotation.edit.view.js | 2 +- frontend/vre/annotation/annotation.edit.view.mustache | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/frontend/vre/annotation/annotation.edit.view.js b/frontend/vre/annotation/annotation.edit.view.js index fcf50eb9..d393c41f 100644 --- a/frontend/vre/annotation/annotation.edit.view.js +++ b/frontend/vre/annotation/annotation.edit.view.js @@ -5,7 +5,7 @@ import confirmDeletionTemplate from './annotation.confirm.deletion.mustache'; import {glossary} from "../utils/glossary"; export var AnnotationEditView = View.extend({ - tagName: 'tr', + tagName: 'div', className: 'form-inline', template: annotationEditTemplate, glossaryTemplate: annotationTagEditTemplate, diff --git a/frontend/vre/annotation/annotation.edit.view.mustache b/frontend/vre/annotation/annotation.edit.view.mustache index 2bdfd2ad..12f859ee 100644 --- a/frontend/vre/annotation/annotation.edit.view.mustache +++ b/frontend/vre/annotation/annotation.edit.view.mustache @@ -1,4 +1,4 @@ -