Commit 73e0b72
authored
fix: handle expired gh CLI tokens and macOS restricted file access (#533)
## Summary
Fixes two classes of user-reported failures:
1. **GitHub API 403s when the `gh` CLI token is expired.** The module
attaches the token from `gh auth token` to API requests; when that token
is expired or has insufficient scopes, `api.github.com` returns 403 and
the deployment fails with a misleading downstream error (`The release v
does not exist...`).
2. **macOS file access errors** on protected paths when reading files
without `-Force`.
## Changes
### GitHub auth resiliency
- `Invoke-GitHubApiRequest`: when the attached `gh` token causes a
401/403, automatically retry once without auth (anonymous, subject to
rate limits) and warn the user to run `gh auth login`. Applies to all
three code paths (file download, `SkipHttpErrorCheck`, standard API
call). Factored repeated logic into `Disable-AuthAndWarn` and
`Get-StatusCodeFromError` helpers.
- `Get-GithubReleaseTag`: on 401/403, throw an actionable error naming
the likely cause (expired gh token or rate limiting) and the fix (`gh
auth login`) instead of the generic "check your internet connection"
message.
- `Test-NetworkConnectivity`: inspect the status code from the
`api.github.com` probe and record 401/403 as a Failure with the same
guidance, so connectivity checks surface this issue up front.
### macOS file access
- Added `-Force` to every `Get-Item`, `Get-ChildItem`, and `Get-Content`
call across the module so reads succeed on macOS paths where
hidden/protected attributes would otherwise block access. (`Test-Path` /
`Resolve-Path` intentionally untouched — they do not support `-Force`.)
### UX
- `Get-AzureContext`: clarified that "Querying Azure for management
groups, subscriptions, and regions..." can take up to 30 seconds.
## Testing
- `Invoke-Build -File .\src\ALZ.build.ps1` — passes locally.
- Existing `Test-NetworkConnectivity.Tests.ps1` still covers the mocked
success/failure paths.1 parent 7832440 commit 73e0b72
21 files changed
Lines changed: 107 additions & 42 deletions
File tree
- src
- ALZ
- Private
- Config-Helpers
- Deploy-Accelerator-Helpers
- Tools/Checks
- Public
- Tests/Unit/Private
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
7 | 8 | | |
8 | 9 | | |
9 | 10 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
| 23 | + | |
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
| 25 | + | |
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
| 34 | + | |
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
| 52 | + | |
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
70 | | - | |
| 70 | + | |
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
| |||
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
| 43 | + | |
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
47 | | - | |
| 47 | + | |
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
| |||
60 | 60 | | |
61 | 61 | | |
62 | 62 | | |
63 | | - | |
| 63 | + | |
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
| 15 | + | |
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| |||
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
132 | 132 | | |
133 | 133 | | |
134 | 134 | | |
135 | | - | |
| 135 | + | |
136 | 136 | | |
137 | 137 | | |
138 | 138 | | |
| |||
145 | 145 | | |
146 | 146 | | |
147 | 147 | | |
148 | | - | |
| 148 | + | |
149 | 149 | | |
150 | 150 | | |
151 | 151 | | |
| |||
215 | 215 | | |
216 | 216 | | |
217 | 217 | | |
218 | | - | |
| 218 | + | |
219 | 219 | | |
220 | 220 | | |
221 | 221 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
177 | 177 | | |
178 | 178 | | |
179 | 179 | | |
180 | | - | |
| 180 | + | |
181 | 181 | | |
182 | 182 | | |
183 | 183 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
178 | 178 | | |
179 | 179 | | |
180 | 180 | | |
181 | | - | |
| 181 | + | |
182 | 182 | | |
183 | 183 | | |
184 | 184 | | |
| |||
192 | 192 | | |
193 | 193 | | |
194 | 194 | | |
195 | | - | |
| 195 | + | |
196 | 196 | | |
197 | 197 | | |
198 | 198 | | |
| |||
0 commit comments