Fixart ls root (#55)

* Expand bare art:// to the configured Artifactory root

With ARTIFACTORY_BASE_URL (or ART_BASE_URL) set, `art://` now resolves
to the configured service root, so `asanypath ls art://` lists
repositories with the scoped environment token. Without a base URL, a
host-less Artifactory path raises an error naming the setting instead
of the misleading "token required" error.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Use one Artifactory keyring entry per service

The service key is now derived from the normalized endpoint, so
`art://host/artifactory` and paths below it share the cached token
entry `art:host/artifactory`. Previously the bare service root used
`art:host`; a token cached only through the root must be supplied once
more.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: hoshimura

src/asanypath/artifactory.py

@@ -137,6 +137,11 @@ def __init__(self, *args, token: str | None = None, **kwargs):
         """
         super().__init__(*args, **kwargs)
         self._bind_path_attrs()
+        if not self._service_key:
+            raise ValueError(
+                "Artifactory path needs a host (art://<host>/artifactory/...), "
+                "or set ARTIFACTORY_BASE_URL to use art:// shorthand."
+            )
 
         from asanypath import _credstore
 
@@ -191,12 +196,10 @@ def _env_token(self) -> str | None:
 
     @property
     def _service_key(self) -> str:
-        """``host/artifactory``: the service key for the keyring, the JFrog CLI
-        config and token scoping. Derived as before endpoint normalization so
-        stored credentials keep matching."""
-        raw = str(self)[len("art://") :]
-        idx = raw.find("/artifactory/")
-        return raw[: idx + len("/artifactory")] if idx >= 0 else raw.split("/")[0]
+        """``host/artifactory`` (or ``host``): the service key for the keyring,
+        the JFrog CLI config and token scoping. Same for the service root and
+        every path below it."""
+        return self._endpoint_url.removeprefix("https://")
 
     @property
     def _item_path(self) -> str:

src/asanypath/common.py

@@ -472,6 +472,7 @@ def _expand_protocol_base_url(self, part: str) -> str:
 
         Example with ARTIFACTORY_BASE_URL=artifacts.example.com/artifactory:
         art://repo/path -> art://artifacts.example.com/artifactory/repo/path
+        art:// -> art://artifacts.example.com/artifactory
         """
         if self.protocol == "file":
             return part
@@ -494,6 +495,9 @@ def _expand_protocol_base_url(self, part: str) -> str:
         normalized = scheme_re.sub(f"{self.protocol}{SCHEME_SEP}", part, count=1)
         normalized_rest = normalized.split(SCHEME_SEP, 1)[1].lstrip("/")
         base_prefix = base_prefix.rstrip("/")
+        if not normalized_rest:
+            # The bare root (e.g. ``art://``) is the configured service root.
+            return f"{self.protocol}{SCHEME_SEP}{base_prefix}"
         if normalized_rest == base_prefix or normalized_rest.startswith(f"{base_prefix}/"):
             return normalized
 

tests/test_artifactory.py

@@ -361,6 +361,40 @@ def test_art_scheme_dispatch():
         assert isinstance(p, ArtifactoryPath)
 
 
+@pytest.mark.parametrize("setting", ["ARTIFACTORY_BASE_URL", "ART_BASE_URL"])
+async def test_bare_scheme_is_configured_service_root(monkeypatch, setting):
+    """``art://`` is the configured service root: env token allowed, repos listed."""
+    from asanypath import AsAnyPath
+    from asanypath.common import _BASE_URL_PREFIX_CACHE
+
+    _BASE_URL_PREFIX_CACHE.clear()
+    monkeypatch.setattr(ArtifactoryPath, "_env_config", None)
+    monkeypatch.setenv(setting, "https://artifactory.example.com/artifactory/")
+    monkeypatch.setenv("ARTIFACTORY_IDENTITY_TOKEN", "env-token")
+    try:
+        root = AsAnyPath("art://")
+        assert str(root) == "art://artifactory.example.com/artifactory"
+        assert root._token == "env-token"
+        with patch(
+            "asanypath.artifactory.art_list_repos",
+            new=AsyncMock(return_value=["generic"]),
+        ) as mock:
+            assert [str(x) async for x in root.iterdir()] == [
+                "art://artifactory.example.com/artifactory/generic"
+            ]
+        assert mock.await_args.kwargs["base_url"] == "https://artifactory.example.com/artifactory"
+    finally:
+        _BASE_URL_PREFIX_CACHE.clear()
+
+
+def test_bare_scheme_without_base_url_names_the_setting(monkeypatch):
+    from asanypath.common import _BASE_URL_PREFIX_CACHE
+
+    _BASE_URL_PREFIX_CACHE.clear()
+    with pytest.raises(ValueError, match="ARTIFACTORY_BASE_URL"):
+        ArtifactoryPath("art://", token="tok")
+
+
 # ----------------------------------------------------------------------
 # Credstore wiring
 # ----------------------------------------------------------------------
@@ -392,6 +426,28 @@ def test_artifactory_explicit_token_is_saved(monkeypatch):
     assert saved[0][0].startswith("art:")
 
 
+@pytest.mark.parametrize(
+    "path",
+    [
+        "art://h.example.com/artifactory",
+        "art://h.example.com/artifactory/",
+        "art://h.example.com/artifactory/repo",
+        "art://h.example.com/artifactory/repo/dir/file.txt",
+    ],
+)
+def test_artifactory_cached_token_key_is_per_service(monkeypatch, path):
+    """The service root and paths below it share one keyring entry."""
+    from asanypath import _credstore
+
+    monkeypatch.setattr(ArtifactoryPath, "_service_tokens", {})
+    loaded: list = []
+    monkeypatch.setattr(_credstore, "load", lambda key, **_: loaded.append(key) or "cached")
+    with patch.dict("os.environ", {}, clear=True):
+        ArtifactoryPath._env_config = None
+        ArtifactoryPath(path)
+    assert loaded == ["art:h.example.com/artifactory"]
+
+
 def test_artifactory_loads_token_from_jfrog_cli_conf(tmp_path, monkeypatch):
     """No token/env/credstore → falls back to the JFrog CLI config."""
     import json